- Issue created by @djsagar
- Assigned to ahsannazir
- Status changed to Needs work
about 1 year ago 4:29am 18 January 2024 - Status changed to Needs review
about 1 year ago 5:13am 18 January 2024 - Issue was unassigned.
- Assigned to Sandeep_k
- 🇮🇳India Sandeep_k New Delhi
Hi @ahsannazir, I've Tested the shared MR- MR !363 mergeable on the Drupal- 10.2.2-dev version, The Patch was applied successfully and looks good to me.
Testing Steps:
- Install the theme set as an administration theme.
- Configure the layout builder module for a content type & create a new content node or open an existing node for that content type.
- Go to the layout in the node- to see the before results (Before result attached)
- Download the shared patch & apply.
- Go to the content node again to re-verify this.
Testing Results:
After applying the patch, the unwanted message icon is removed now. RTBC++ - Issue was unassigned.
- Status changed to RTBC
about 1 year ago 6:47am 18 January 2024 - Status changed to Needs work
about 1 year ago 9:54am 18 January 2024 - 🇨🇭Switzerland saschaeggi Zurich
I've left some code suggestions. Please have a look 👀
- Status changed to Needs review
about 1 year ago 10:40am 18 January 2024 - 🇮🇳India djsagar
I have done changes which is suggested by @saschaeggi in #8 and create MR kindly review.
- 🇨🇭Switzerland saschaeggi Zurich
I can't see any changes in the correct MR https://git.drupalcode.org/project/gin/-/merge_requests/363
So I'll move this back to needs work
- Status changed to Needs work
about 1 year ago 12:50pm 18 January 2024 - 🇨🇭Switzerland saschaeggi Zurich
saschaeggi → changed the visibility of the branch 8.x-3.x to hidden.
- Status changed to Needs review
about 1 year ago 1:21pm 18 January 2024 - 🇨🇭Switzerland saschaeggi Zurich
Thank you @djsagar LGTM, needs a review now 👍
- 🇮🇳India Sandeep_k New Delhi
@djsagar, I've tried applying the latest Patch- MR !363 mergeable on drupal 10.2 version. The patch wasn't applied successfully, Sharing the error attached.
- Status changed to RTBC
about 1 year ago 10:11am 22 January 2024 Hi, I have tested the MR !363 and the changes look good. Attached after screenshot for reference. Moving to RTBC
After fix -
Thanks
- Status changed to Fixed
about 1 year ago 12:31pm 31 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.