Add styles for block navigation label

Adjusting summary.

This code already defined.
Please check.

Thanks, MR updated, very detailed answer written. Please check

That was planned as BEM block and not Drupal. Idk what else can appear in toolbar. Not sure we have to strictly relate them to Drupal entities here.

New changes are based on BEM methodology aswell (sorry for wrong status)

New changes are based on BEM methodology aswell

I see here `toolbar-block` and `navigation-block`...

I can agree that they do not contradict the BEM, but they clearly do not follow it. I see that a second (duplicate) block has appeared just to replicate the Drupal structure. Which, it seems to me, is not final at the moment. So this new file seems like an unnecessary complication to me.

But I'll leave this for review by other community members.

I would move `toolbar-block` BEM block on top of drupal's block. Again - we are rendering blocks with menus inside. Blocks can render label and content. So i'm thinking if `toolbar-block` classname should be added to `navigation-block.html.twig` as a wrapper. For menus inside - can be just `toolbar-block__menu` or `toolbar-block__section`.

ckrina → closed merge request !163

ckrina → reopened merge request !163

This needs to be manually rebaded.

I resolved the merge conflict.

ckrina → closed merge request !163

ckrina → reopened merge request !163

I agree with @finnsky: both .navigation-block and .toolbar-block are the same component, and this MR keeps the 2 CSS files/components with the title in one and the rest of CSS in the other. But I agree with you @kostyashupenko that CSS and "PHP"-generated classes should match. Here's some the background behind the previous discussion regarding naming and the agreement we reached (before most of the back-end work started): #3387374 and #3386927.

Matching Drupal and BEM structure we have is:
- Navigation&co (wrapper, content...)
- Block (as Drupal block) and .toolbar-block<-- Here is where we need to add the label.
- Menu (as Drupal menu) and .toolbar-menu
- Menu links&co

On a back-end perspective we decided to use Navigation to avoid conflicts with the current Toolbar module. I know they don't match for now and they will have to match before opening a MR to core, but I wouldn't make naming changes in a specific MR that is supposed to only change styles. We'll need to properly discuss and plan the naming strategy now that we have both the front-end and back-end more defined, but let's have a discussion to properly bike-shed on that in another issue ;)

So let's keep the existing .toolbar-block for now and re-structure components or naming in a follow-up.

Met with @ckrina today and discussed #19. I moved the title to be back in `toolbar-block.css` with the additions that were added.

finnsky → closed merge request !163

finnsky → reopened merge request !163

Small issue with vertical spacing. Please take a look! All other looks great. Thank you!

ahsannazir → made their first commit to this issue’s fork.

Removed the vertical padding as suggested because there is already ample spacing coming from grid-gap.

Since we've just merged ✨ Reset theme css. Fixed and touches several CSS files, this needs to be rebased wit the latest changes.

Looks good to me in frontend, but i would like to request backender review here. Since it contains some php.

See MR comments. A couple of code changes are needed here.

I see it not works now. Gonna fix

Code looks good to me!

Left a minor comment in the MR.

There was some misunderstanding in begin so we had 2 definitions.
Now fixed

Merged! Thanks all for the work here. This finished a really nice to have feature for the navigation!

Automatically closed - issue fixed for 2 weeks with no activity.