- Issue created by @gorkagr
- π§πͺBelgium gorkagr
Can be the test fails as i left
@ingroup plugin_translatable
but the var now is set as\Drupal\Core\Annotation\Translation|array
? or it is not related and failed another thing? - Status changed to Needs review
11 months ago 6:18pm 18 January 2024 - πΊπΈUnited States smustgrave
Left a comment but MR appears to still be in draft.
- π§πͺBelgium gorkagr
Sorry, i forgot to remove the draft the last time.
Replied to the comment with one example where an array is used in core :) - Status changed to RTBC
11 months ago 3:22pm 2 February 2024 - πΊπΈUnited States smustgrave
Believe my 1 question has been addressed.
- Status changed to Needs work
11 months ago 5:48pm 3 February 2024 - Status changed to Needs review
11 months ago 3:22pm 4 February 2024 - Status changed to RTBC
11 months ago 5:42pm 6 February 2024 - π³πΏNew Zealand quietone
I'm triaging RTBC issues β . I read the IS, the comments and the MR. I didn't find any unanswered questions or other work to do.
Leaving at RTBC.
- Status changed to Needs work
10 months ago 1:17pm 1 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Where in the code is description set to an array? I don't think this part of the change is correct. Category is now a string. And we should link to \Drupal\Core\Field\FieldTypeCategoryManager here now because this string should be a field type category plugin.
- π¬π§United Kingdom alexpott πͺπΊπ
Oh I see... in things like \Drupal\Core\Field\Plugin\Field\FieldType\TimestampItem - now that's an odd change. But hey ho.
So I think we should still improve this to say that when you provide an array it'll be used to create a bulleted list - if it is not an array then it'll be just displayed as a sentence.
And we should link the category to \Drupal\Core\Field\FieldTypeCategoryManager and say it should match a field type category plugin ID
- π¬π§United Kingdom alexpott πͺπΊπ
Is it possible for someone to add a new CR to β¨ Make field selection less overwhelming by introducing groups Fixed about the support for an array of translatable strings in the field type plugin definition and what it does.