- Issue created by @shubhamsprasad
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- If you have not done it yet, you should run
- 🇮🇹Italy apaderno Brescia, 🇮🇹
As a side note, please check you set Git to use the email address associated to your drupal.org account. Differently, your commits will not be associated to your account.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Remember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.
- Status changed to Needs review
11 months ago 5:42am 10 January 2024 - Status changed to Active
11 months ago 10:56am 10 January 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Since this application has been created by shubhamsprasad, we expect that any status change is done by shubhamsprasad, who is the only person who can make commits in the project for the time this application is open.
- Status changed to Needs review
11 months ago 11:05am 10 January 2024 - 🇮🇳India rushiraval
I am changing the issue priority as per issue priorities → .
The code looks good to me. There aren't a lot of commits on the dev branch for some reason. There are more commits on 1.0.3.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution and for your patience with the review process!
I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.
These are some recommended readings to help you with maintainership:
- Dries → ' post on Responsible maintainers
- Maintainership →
- Git version control system →
- Issue procedures and etiquette →
- Maintaining and responding to issues for a project →
- Release naming conventions → .
You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank the dedicated reviewers as well.
- Status changed to Fixed
4 months ago 2:20am 4 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.