Contrib.social

Improve NotBlank DX in config (schema) validation

Open on Drupal.org →
Created on 8 January 2024, 9 months ago

Problem/Motivation

Surfaced at 📌 Add validation constraints to block_content.type.* Needs work , specifically at https://git.drupalcode.org/project/drupal/-/merge_requests/5170/diffs#no...

🐛 When setting `NotNull` constraint on type: required_label, two validation errors appear Needs review improved the DX for using NotBlank in the "required value" case.

But turns out that in the "optional value" case, we can improve it too!

Steps to reproduce

Proposed resolution

Always set $constraints['NotBlank']['allowNull'] = TRUE; because:

  1. when it is required (i.e. nullable: false, which is the default), null will trigger the NotNull constraint, and NotBlank should not generate an equivalent message again
  2. when it is optional (i.e. nullable: true, which must be explicitly specified), then null is a valid value and NotBlank should not complain

Remaining tasks

  1. ✅ Tweak the infrastructure.
  2. ✅ Prove the DX impact by simplifying node.schema.yml.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Configuration  →

Last updated 2 days ago

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024