- Issue created by @s_castro
- Status changed to RTBC
11 months ago 6:33am 6 January 2024 - 🇮🇳India rushiraval
I have applied this patch on Drupal 10 using PHP 8.2 with PgSql.
It working finel. so Moving it to RTBC+
Hello,
I noticed an error after installing the module and going to the "Require Revision Log Messages" form:
Deprecated function: Creation of dynamic property Drupal\require_revision_log_message\Form\SettingsForm::$entityTypeManager is deprecated in Drupal\require_revision_log_message\Form\SettingsForm->__construct() (line 28 of modules/contrib/require_revision_log_message/src/Form/SettingsForm.php).
I went to the code and noticed that the variable $this->entityTypeManager is created dynamically and this is deprecated in PHP 8.2. I also noticed there is a declared variable in this class $entityFieldManager that is not used and I would say the intention at the beginning was to use this instead of $entityTypeManager but at some point the names were confused.
Rename the variable $entityFieldManager to $entityTypeManager and change the declaration as required.
I have applied this patch on Drupal 10 using PHP 8.2 with PgSql.
It working finel. so Moving it to RTBC+