[1.1.x] Google Analytics GA4

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

There is no branch with name 1.1.

master is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .

Hi Vishal Kadam, thanks for the suggestions. I have created a branch, '1.1'. Could you please suggest the next steps for security advisory coverage?

1.1.2 and master are wrong names for a branch and should be removed.

I have addressed all the PHPCS-related issues and have also removed the master and 1.1.2 branches to ensure coverage for the Drupal.org security advisory. Could you please review the changes?

https://git.drupalcode.org/project/tui_image_editor/-/commit/a6b20c7679b... is not the correct security fix FWIW

Google analytics module already handles GA4 right? Why is another module needed?

Adding context to #12

I had pinged @larowlan in 🐛 XSS via block settings Fixed .

larowlan had reported a security issue (privately) to the applicant over a year ago on another module the applicant maintains. The applicant did not respond to the private report and the issue was made public to ensure users of the module would be aware of the risks. The applicant later committed part of the fix suggested in the issue. Part of the suggested fix however was not committed and when questioned the applicant did not respond to inquires. The issue remained open awaiting response.

Yesterday the applicant marked the issue as Closed(fixed) (skipping the standard Fixed stage and auto closure) without providing any feedback with regards to the (year long) remaining concerns that still have not been committed.

While it is not the module the applicant requested to be reviewed the conduct does raise possible questions about about the applicants ability to write secure code and resolve security issues presented to them that should be considered before granting the applicant the permission to opt projects into security coverage.

Given the warning given in the Google Analytics project page → , I would say that module already supports Google Analytics 4. Creating another project is not necessary.

Users must upgrade to Google Analytics 4.0.2 (Drupal 9.3+), 4.0.1 (Drupal 8+), or 7.x-2.8+ before the legacy GA service shuts down July 1st 2023.

I am changing priority as per Issue priorities → .

This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application. If you are no longer pursuing this application then I mark it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to set the issue status to Needs work or Needs review, depending on the current status of your code.