- Issue created by @kim.pepper
- Merge request !5974Issue #3411266 Convert file_icon_class() and file_icon_map() to a utlity class and deprecate β (Closed) created by kim.pepper
- Status changed to Needs review
about 1 year ago 11:53pm 28 December 2023 - Status changed to RTBC
about 1 year ago 5:39pm 29 December 2023 - πΊπΈUnited States smustgrave
Applied the MR and searched for file_icon_class + file_icon_class and only one instance of each which was deprecated.
Tests are added to show deprecation, https://git.drupalcode.org/issue/drupal-3411266/-/jobs/544804
LGTM
- First commit to issue fork.
- π³πΏNew Zealand quietone
I moved the
cspell:ignore
line. It should be before the class declaration and after any use statements. I used the Web IDE an had the pleasure of making the change twice. :-)Leaving at RTBC.
- π¬π§United Kingdom longwave UK
Wondered if it was worth making this extensible or swappable but I searched the issue queue and found no issues discussing either of these, so I think this is fine just to move to a static utility class, especially given each method only has exactly one usage in core.
Committed c936bda and pushed to 11.x. Thanks!
-
longwave β
committed c936bda0 on 11.x
Issue #3411266 by kim.pepper, quietone, smustgrave: Convert...
-
longwave β
committed c936bda0 on 11.x
- Status changed to Fixed
12 months ago 1:17pm 18 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.