- Issue created by @joachim
- First commit to issue fork.
- Merge request !6284Issue #3411219 by shivam-kumar: hook only invoked if $settings_form is empty → (Open) created by shivam-kumar
- Status changed to Needs review
8 months ago 10:28am 23 January 2024 - 🇮🇳India shivam-kumar
Optimized the code. if $settings_form is non-empty, then the hook_field_widget_third_party_settings_form() is not called. moved to needs review.
- Status changed to Needs work
8 months ago 10:59am 23 January 2024 - 🇬🇧United Kingdom joachim
Thanks for the MR.
Needs some work on the nesting and conditions.
You probably want something more like (rough pseudocode)
if (empty(settings)) { $3rdparty = get3rdparty(); } if (!empty(settings) || !empty($3rdparty) { form array }
empty() works with undefined variables, so it's fine to check $3rdparty like that.
- Status changed to Needs review
8 months ago 5:36am 24 January 2024 - 🇮🇳India shivam-kumar
Hey thanks @joachim, Have done the changes as per suggestion. Moving it to needs review.
- Status changed to RTBC
8 months ago 12:00pm 24 January 2024 - Status changed to Needs review
7 months ago 9:05am 19 February 2024 - 🇳🇿New Zealand quietone New Zealand
What nice change.
I'm triaging RTBC issues → . I read the IS, the comments and the MR. I didn't find any unanswered questions.
The comment in the MR was not wrapped correctly. I fixed that by rewording the comment. Setting to needs review for that to be checked.
- Status changed to Needs work
7 months ago 5:04pm 21 February 2024