Fix the errors/warnings reported by PHP_CodeSniffer

I've created a MR.

FYI, I've added a phpcs.xml file to exclude warnings from the Drupal.Semantics.FunctionT.NotLiteralString rule.
If you have any suggestions for appropriately fixing these warnings, please do not hesitate to share them.

The issue needs review.

Hi

I applied the MR !6 and it fixes most of the PHPCS issues but there is still a PHPCS errors

➜  date_range_formatter git:(9.0.x) curl https://git.drupalcode.org/project/date_range_formatter/-/merge_requests/6.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7372    0  7372    0     0  14690      0 --:--:-- --:--:-- --:--:-- 14892
patching file date_range_formatter.install
patching file date_range_formatter.module
patching file phpcs.xml
patching file 'src/Plugin/Field/FieldFormatter/DateRangeFormatterRangeFormatter.php'
➜  date_range_formatter git:(9.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml date_range_formatter 

FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/date_range_formatter/date_range_formatter.info.yml
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------------------------------


FILE: ...ubing-subing/Projects/d9/d9-local/web/modules/contrib/date_range_formatter/src/Plugin/Field/FieldFormatter/DateRangeFormatterRangeFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
 70 | WARNING | Only string literals should be passed to t() where possible
 84 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 272ms; Memory: 10MB

➜  contrib git:(master) ✗ 

I've fixed the module dependency warning and updated the MR.

Regarding the translation warnings I mentioned above, I've added a phpcs.xml file. This means you need to run the phpcs command directly in the module folder to allow phpcs to take into account all the provided exclusions.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

I don't believe that removing translation functions is the best approach here. Someone may already have translated some strings on their sites, and removing these functions could probably cause some issues. This issue requires further consideration.

BTW, I'm currently running the PHPCS command in the project folder, and it isn't showing any issues. Could someone else try running the command?

I am modifying some arguments in the PHPCS command to utilize the appropriate phpcs.xml file during command execution.

Another method to bypass these errors is to use the ignore command, as in Drupal.Semantics.FunctionT.NotLiteralString.

However, creating a phpcs.xml file seems like a more suitable approach in this context.

$this->t() is not the correct way to translate configuration object values. For that, there is a specific API that needs to be used, which is also documented on drupal.org.

Yeah, but these settings are part of a formatter field form.

As far as I know, we are unable to translate them because the issue 🐛 Entity view/form mode formatter/widget settings have no translation UI Needs review is still in progress.

If that is the only way to get translated strings in that specific context, I would leave the code as it is. I think it is more important to get translated strings than a PHP_CodeSniffer report without errors/warnings.
Once 🐛 Entity view/form mode formatter/widget settings have no translation UI Needs review get fixed, the code can be changed.

Absolutely. Because of that, I've just added a sniffer rule to avoid unnecessary warnings. We just need a review rn.

Thanks for MR, please check my feedback.

There are more changes in the MR, then we have in the phpcs report in the issue.
I don't want to fix issues that is reported by phpcs in this issue.
Can you please update report in the IS?

I'll update the MR according to your feedback. Thanks

All threads seem to have been resolved. @nikolay-shapovalov, could you take a look at this?

Taras, thanks a lot, changes looks good. Please check my question.

Can you please update IS, and provide fresh phpcs report?

Yep, I'll do this soon

I'm returning the entire PHPCS log to the IS as @nikolay-shapovalov has mentioned above.

Btw, the .module file has been removed.

Removing the PATCHES.txt file from the log

Great work, thanks. RTBC.