- Issue created by @claudiu.cristea
- First commit to issue fork.
- π¬π§United Kingdom jonathan1055
I've posted back on β¨ Make field selection less overwhelming by introducing groups Fixed with a link to this issue.
- Status changed to Needs work
8 months ago 10:23am 7 January 2024 - π¬π§United Kingdom jonathan1055
Yes the wrong trigger message was changed in the first commit. Its the one around line 103
https://www.drupal.org/node/3364271
which gives a 404.The MR needs a rebase that that isn't working for me, so I can't offer the change.
- π¬π§United Kingdom jonathan1055
The issue β¨ Make field selection less overwhelming by introducing groups Fixed which added the incorrect url has two CRs
"CR New API for defining field type categories" https://www.drupal.org/node/3375748 β
"FieldStorageAddForm has new structure" https://www.drupal.org/node/3364263 βNeither of these urls appear in any trigger_error in the code base. Which one is the correct one to replace 3364271?
- Status changed to Needs review
8 months ago 1:55pm 7 January 2024 - Status changed to RTBC
8 months ago 4:50pm 7 January 2024 - π¬π§United Kingdom jonathan1055
I recall that some (all?) of the new
trigger_error
deprecation messages should have test coverage? This one does not have any test coverage, because I only changed the url in one place and the tests passed. If the trigger_error was covered in a test then shouldn't that url also be included in a test file? - π¬π§United Kingdom catch
Not for every deprecation message - if it's something 'best effort' like a constructor deprecation we don't bother. However this is more of a real API deprecation so we might want one yeah. Generally I think we should only add deprecation testing where there's a backwards compatibility code path that has some level of complexity, since these tests are very short-lived compared to any other core tests.
Could probably open a follow-up for that, but I'm not clear how much of an API the original string API we're deprecating actually was, so leaving RTBC and see if someone knows.
- π¬π§United Kingdom jonathan1055
@drumm has added a redirect so that https://www.drupal.org/node/3364271 β is sent to the correct 3375748 CR
- Status changed to Fixed
8 months ago 10:11am 9 January 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.