Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in shurly_validate_long()

I've added a check for whether or not the third parameter is null. Please test this patch.

chetan 11 → made their first commit to this issue’s fork.

Hi,
Please check the above MR.

Hi, tested MR, thanks!

If the $long_url parameter is empty, something very strange is happenning, as you're trying to validate an empty URL.

Normally the solution I would do here would be to add this code at the start of the shurly_validate_long() function:

if (empty($long_url)) {
  return FALSE;
}

Can you please check if this fixes the warning, and if the code still works as before?

Guess there's no answer here.

Hi,
Sorry for late reply.
With Patch https://www.drup al.org/files/issues/2023-12-19/3409669.patch warning still occured.
But with check of https://www.drupal.org/project/shurly/issues/3409669#comment-15406117 🐛 Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in shurly_validate_long() Closed: cannot reproduce it seems to be gone away.

Can you please build this in the patch please?
Thanks in advance,
greetings,

Hi @Summit,

I have created patch of #7. Please review it.

Thanks.

RTBC as per #9

Hi, Patch is working. Greetings,

jcnventura → closed merge request !15

Automatically closed - issue fixed for 2 weeks with no activity.