- Issue created by @quietone
- Status changed to Needs review
9 months ago 9:53am 18 December 2023 - Status changed to RTBC
9 months ago 2:16pm 18 December 2023 - πΊπΈUnited States smustgrave
Applied the MR and ran the search and there are 4 returns
1 core/lib/Drupal/Core/Database/Connection.php = Not related to module
2 core/lib/Drupal/Core/Password/PhpPassword.php = Not related to module
3 core/modules/comment/comment.module = Not related to module
4 core/modules/comment/tests/src/Functional/CommentBookTest.php = IS related to the moduleI'm making an assumption that CommentBookTest will be fixed when tests are moved.
- π³πΏNew Zealand quietone New Zealand
I'm making an assumption that CommentBookTest will be fixed when tests are moved.
It is being done in π Move non-migration book-related tests to the Book module RTBC
- Status changed to Needs work
8 months ago 12:22pm 12 January 2024 - Status changed to Needs review
8 months ago 12:44pm 12 January 2024 - π³πΏNew Zealand quietone New Zealand
There were conflicts in two files but it was straightforward.
- Status changed to RTBC
8 months ago 1:13pm 12 January 2024 - Status changed to Needs work
8 months ago 1:31pm 12 January 2024 - π¬π§United Kingdom longwave UK
test.sh from the hook_help accessibility issue has been accidentally added.
- π³πΏNew Zealand quietone New Zealand
Right, that is what happens when you make a simple change just before going to be.
Should be fixed now.
- Status changed to Needs review
8 months ago 10:54pm 12 January 2024 - Status changed to RTBC
8 months ago 2:05am 13 January 2024 - πΊπΈUnited States smustgrave
My mistake in #8, saw green.
See test.sh is removed.
- Status changed to Needs work
8 months ago 4:13pm 14 January 2024 - πΊπΈUnited States xjm
This looks good overall. I left one suggestion on the MR for a comment that went weird, and another question.
Thanks!
- πΊπΈUnited States xjm
Also, I looked at the remaining usages and I think we should also update this bit from
comment.module
:* Users can post comments to discuss a story, collaborative book page, user * etc.
- πΊπΈUnited States xjm
Also, this issue seems to address docblock comments, but there are still a number of inline comments that also reference the book module:
[ayrton:drupal | Sun 10:18:18] $ grep -ri "\bbook\b" * | grep "//" | grep -v "core/modules/book" | grep -v "vendor" | grep -v "node_modules" | grep -vi "migrate" core/tests/Drupal/KernelTests/Core/Asset/LibraryDiscoveryIntegrationTest.php: // Simulate starterkit_theme defining the book-navigation library. core/tests/Drupal/KernelTests/Core/Asset/LibraryDiscoveryIntegrationTest.php: // Activate the theme that extends the book-navigation library in core/lib/Drupal/Core/Database/Connection.php: * @see http://php.net/manual/book.pdo.php core/lib/Drupal/Core/Password/PhpPassword.php: * @see https://www.php.net/manual/en/book.password.php core/modules/image/tests/src/Functional/ImageStylesPathAndUrlTest.php: // (cf. http://www.libpng.org/pub/png/book/chapter08.html#png.ch08.div.2) core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php: // Make sure the book node exists. core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php: // Ensure that the Book module's node type does not have duplicated enforced core/modules/system/src/Plugin/ImageToolkit/GDToolkit.php: $descriptions[] = $this->t('The GD Library for PHP is enabled, but was compiled without support for functions used by the rotate and desaturate effects. It was probably compiled using the official GD libraries from the <a href="https://libgd.github.io/">gdLibrary site</a> instead of the GD library bundled with PHP. You should recompile PHP --with-gd using the bundled GD library. See <a href="https://www.php.net/manual/book.image.php">the PHP manual</a>.'); core/modules/views/tests/src/Kernel/TestViewsTest.php: // `node.type.book` config entity is a config dependency. core/modules/views/tests/src/Kernel/TestViewsTest.php: // `node.type.book` config entity is a config dependency.
Some of those are not relevant, but others definitely reference the book module.
Saving credits.
- Status changed to Needs review
8 months ago 2:38am 15 January 2024 - π³πΏNew Zealand quietone New Zealand
The usages in book in comments listed in #15 are all in tests and tests are done in separate issues. We have already done one π Remove use of book in non profile and update tests Fixed . I just made one for the tests in #15, π Remove usages of book module from tests Active .
Updating the title for clarity.
- Status changed to RTBC
8 months ago 7:48pm 18 January 2024 - πΊπΈUnited States smustgrave
Changes appear to have been addressed.
Liked the replacement of "my_module.settings" that should stand the test of time and any future deprecations.
-
larowlan β
committed 7aaa7533 on 11.x
Issue #3409407 by quietone, smustgrave, xjm, longwave: Remove Book...
-
larowlan β
committed 7aaa7533 on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Thanks folks.
Looks good to me
Committed to 11.x
- Status changed to Fixed
7 months ago 7:10am 29 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.