Remove use of book in non profile and update tests

Did a light search but found

CommentBookTest
HandlerAllTest
TestViewsTest

Are also using book.

I didn't do a full check, but I assume they are handled in 📌 Move non-migration book-related tests to the Book module RTBC .

That one is for moving tests which actually test the book module to the book module.
This one is for handling tests that are "accidentally" using book, but are not using it for something that has specifically to do with book.

The IS (which I wrote isn't really helpful, sorry)

If that's the only one the change looks good. We had something similar with tour module deprecation where there was 1 test that had to be tweaked. Was complex haha

If that's the only one the change looks good.

I think it is.

We had something similar with tour module deprecation where there was 1 test that had to be tweaked. Was complex haha

Tell me about, the ~15 lines of code in this MR almost took me 4 hrs...

Sorry to be a pain after the four hours, but I think we can delete this entire test method instead, for the following reasons:

1. There is no such thing as a 'content type module' any more - the test dates from before bundle entities, when we still had hook_node_type() or whatever it was called in Drupal 7, so the situation it was designed to test doesn't really exist in the same way now.

2. CommentUninstallTest has kernel test coverage for the uninstall case (field_purge_batch() etc.), which is the only tricky thing the test actually covers now.

I got to this because I was wondering why we were modifying a test to delete a node type added by entity_test module, then saw the default config, then realised the mismatch between what the test thinks it's testing and what actually happens since 2014 or whenever things changed.

Spokje → closed merge request !5988

Spokje → changed the visibility of the branch 3376369-remove-use-of to hidden.

Spokje → changed the visibility of the branch 11.x to hidden.

Sorry to be a pain after the four hours

No worries, it was quite educational.

but I think we can delete this entire test method instead,

Test deleted.

Simple review then.

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Spokje → closed merge request !6124

Automatically closed - issue fixed for 2 weeks with no activity.