Deleting a workflow can lead to the deletion of unaffected views

• Used a clean(ish) Umami install, no contrib installed
• Added a new workflow
• Gave the authenticated user permissions for this workflow
• Added the role based permission for authenticated users to a View
• Deleted the new Workflow
• View was still there

Am I missing steps? Can you reproduce this on a clean Drupal install?

Yes. I did not check this on a clean drupal just on another drupal site and with a custom role.

I retested with demo_umami.

Are you saying the steps to reproduce require a patch from 🐛 WorkflowDeleteForm should extend EntityDeleteForm Needs work ?

No. I just mention the patch so that nobody wonders why looks differently.

Yup, the new steps show the problem and the patch certainly helps see it! (strangely enough, it only shows the View getting deleted the second time I try to delete the workflow? Are others seeing that too?)

A little digging, \Drupal\views\Entity\View::onDependencyRemoval gets called with the editor role dependency, which is not getting removed but edited. But the View reacts to it like it's getting removed, and within the context of \Drupal\views\Entity\View::onDependencyRemoval it is impossible to determine if that dependency gets edited or removed. Since it's called 'onDependencyRemoval' I would assume it is only invoked when things get removed? But not sure.

This feels like a configuration management issue from the first little dig I did, so moving it there for now. I don't think Workflows is doing anything wrong, seems more like Views is getting the wrong information, or Views is reaction to the information in the wrong way.

I would have expected that an affected view would at most react like it would upon a missing field: "missing or broken role".