WorkflowDeleteForm should extend EntityDeleteForm

I have changed the base class. Please review.

Thanks - @sidharth_soman please note there is no need to run tests on all available databases, as each test costs the Drupal Association money to run, and it is usually only necessary to run tests once with the default setting by setting the issue to "Needs review".

I think that some of the methods in WorkflowDeleteForm can now also be cleaned up here, as EntityDeleteFormTrait provides them already.

@longwave - I wasn't the one who applied all those tests. I had simply uploaded the patch without adding any tests. Not sure how that happened.

Apologies, I assumed and did not check.

@rushiraval - please see #4 as it appears you added multiple tests here. In most cases just set the status to "Needs review" and a relevant test will be run automatically.

Hello,
I removed the getQuestion(), getCancelUrl(), and getConfirmText() methods because these methods are already provided by the EntityDeleteFormTrait. There's no need to redefine them unless you want to customize their behavior.
The submitForm method has also been removed because EntityDeleteFormTrait handles entity deletion, message display, and redirection automatically.

Please review the patch.

  7 | WARNING | [x] Unused use statement
    |         |     (Drupal.Classes.UnusedUseStatement.UnusedUse)
 27 | ERROR   | [x] Expected 1 blank line after function; 0 found
    |         |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 28 | ERROR   | [x] The closing brace for the class must have an
    |         |     empty line before it
    |         |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)

The last submitted patch, 9: 3377166-7.patch, failed testing. View results →

Please review.

Also interdiffs should be included.

Please review.

Applied patch and confirmed I can still delete workflows without issue

The issue summary pointed out one of the primary reasons this was a problem

Currently a workflow config entity can be deleted without the site admin being aware of consequential configuration changes.

Had there been test coverage to check for this information, the problem would have been caught/addressed much sooner (or never been an issue at all). Lets add tests that validate this fix and prevent it from regressing.