Claro - Views Filter Expose Option Form - Broken HTML

Created on 7 December 2023, about 1 year ago

Updated 14 December 2023, about 1 year ago

This took me so long to figure out.

So I'm working on a new views filter (the boundary filter in the geolocation module here on d.o). That filter has a value form, but currently no operators. This will be important in a moment.

When you open the settings window in the views admin area, you do see label & description, then the value form, and then nothing. All additional options are invisible. They exist in the HTML, but outside of the modal area and can therefor not be interacted with, except using browser tools. See attached image.

The reason for this is, that Claro in claro_form_views_ui_config_item_form_alter() more or less unconditionnally adds 1 open div before the operator form part, and 1 closing div after the value form part, obviously assuming, they would always both be present.

This IMHO already structures additional option form elements in a weired way, when it works as intended, but when there is no operator to begin with, it just breaks. See attached image to get an idea. The --operator part will not be rendered for lack of content.

🐛 Bug report

Status

Postponed: needs info

Version

10.2 ✨

Component

Claro →

Last updated 2 days ago

Maintained by
🇪🇸Spain @ckrina
🇨🇭Switzerland @saschaeggi
🇺🇸United States @bnjmnm
🇫🇮Finland @lauriii

Created by

🇩🇪Germany christianadamski Berlin, Germany

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @christianadamski
Comment about 1 year ago →
🇩🇪Germany christianadamski Berlin, Germany
Created 🐛 showOperatorForm - Do not add empty prefix/suffix Active as a potential follow-up
Status changed to Postponed: needs info about 1 year ago6:12pm 14 December 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
Not suer I fully understand the issue? And does the follow up fix the issue?
Comment about 1 year ago →
🇩🇪Germany christianadamski Berlin, Germany
Quoting Lendude from the linked issue:

The same happens in Gin. Not 100% sure if this is a core issue or if this should be fixed in the themes or in the filter plugin without the operators, but probably cleanest to do it in core.

I'm not sure either.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024