Fix gitlab and test next major

Created on 1 December 2023, about 1 year ago
Updated 17 August 2024, 4 months ago

Problem/Motivation

Fix pipeline and add support for next major/minor so we can cut a D11 version

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States dcam

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dcam
  • Merge request !11Attempted to fix phpstan errors → (Merged) created by dcam
  • 🇺🇸United States dcam

    Additional errors:
    ```
    ------ ---------------------------------------------------------------------
    Line src/ZfExtensionManagerSfContainer.php
    ------ ---------------------------------------------------------------------
    13 Class Drupal\aggregator\ZfExtensionManagerSfContainer implements
    deprecated interface Laminas\Feed\Reader\ExtensionManagerInterface:
    this interface is no longer needed, and shouldn't be relied upon
    13 Class Drupal\aggregator\ZfExtensionManagerSfContainer implements
    deprecated interface Laminas\Feed\Writer\ExtensionManagerInterface:
    this interface is no longer needed, and shouldn't be relied upon
    124 Fetching class constant class of deprecated class
    Laminas\Feed\Reader\ExtensionManagerInterface:
    this interface is no longer needed, and shouldn't be relied upon
    124 Fetching class constant class of deprecated class
    Laminas\Feed\Writer\ExtensionManagerInterface:
    this interface is no longer needed, and shouldn't be relied upon
    ------ ---------------------------------------------------------------------
    ------ -----------------------------------------
    Line tests/src/Functional/ImportOpmlTest.php
    ------ -----------------------------------------
    138 Variable $title might not be defined.
    139 Variable $url might not be defined.
    ------ -----------------------------------------
    ------ --------------------------------------------------------------------------------------------
    Line tests/src/Functional/Plugin/aggregator/processor/DefaultProcessorTest.php
    ------ --------------------------------------------------------------------------------------------
    23 @covers value
    \Drupal\aggregator\Plugin\aggregator\processor\DefaultProcessor::deleteFeedHashes()
    references an invalid method.
    23 @covers value
    \Drupal\aggregator\Plugin\aggregator\processor\DefaultProcessor::submitConfigurationForm()
    references an invalid method.
    ------ --------------------------------------------------------------------------------------------
    ------ -----------------------------------------------------------------------
    Line tests/src/Functional/Update/AggregatorUpdateBrokenRssFeedViewTest.php
    ------ -----------------------------------------------------------------------
    12 @covers value aggregator_update_8606() references an invalid class or
    function.
    💡 The @covers annotation requires a fully qualified name.
    ------ -----------------------------------------------------------------------
    ------ ----------------------------------------------------------------------
    Line tests/src/Functional/Update/AggregatorUpdateDeleteQueueTest.php
    ------ ----------------------------------------------------------------------
    14 @covers value aggregator_post_update_delete_queue_items() references
    an invalid class or function.
    💡 The @covers annotation requires a fully qualified name.
    ------ ----------------------------------------------------------------------
    ------ -----------------------------------------------------------------------
    Line tests/src/Functional/Update/AggregatorUpdateFeedsTest.php
    ------ -----------------------------------------------------------------------
    28 @covers value aggregator_update_8605() references an invalid class or
    function.
    💡 The @covers annotation requires a fully qualified name.
    ------ -----------------------------------------------------------------------
    ------ -----------------------------------------------------------------------
    Line tests/src/Functional/Update/AggregatorUpdateItemsTest.php
    ------ -----------------------------------------------------------------------
    29 @covers value aggregator_update_8604() references an invalid class or
    function.
    💡 The @covers annotation requires a fully qualified name.
    ------ -----------------------------------------------------------------------
    ------ -----------------------------------------------------------------------
    Line tests/src/Functional/Update/AggregatorUpdateRssFeedViewTest.php
    ------ -----------------------------------------------------------------------
    12 @covers value aggregator_update_8601() references an invalid class or
    function.
    💡 The @covers annotation requires a fully qualified name.
    ------ -----------------------------------------------------------------------
    ------ -----------------------------------------------------------------------
    Line tests/src/Functional/Update/AggregatorUpdateSettingsTest.php
    ------ -----------------------------------------------------------------------
    31 @covers value aggregator_update_8602() references an invalid class or
    function.
    💡 The @covers annotation requires a fully qualified name.
    31 @covers value aggregator_update_8603() references an invalid class or
    function.
    💡 The @covers annotation requires a fully qualified name.
    31 @covers value aggregator_update_8607() references an invalid class or
    function.
    💡 The @covers annotation requires a fully qualified name.
    ------ -----------------------------------------------------------------------
    ------ -----------------------------------------------------------
    Line tests/src/Functional/UpdateFeedItemTest.php
    ------ -----------------------------------------------------------
    29 Variable $feed in empty() always exists and is not falsy.
    ------ -----------------------------------------------------------
    ------ ----------------------------------------------------------------------------
    Line tests/src/Kernel/Plugin/aggregator/processor/DefaultProcessorTest.php
    ------ ----------------------------------------------------------------------------
    59 @covers value
    \Drupal\aggregator\Plugin\aggregator\processor\DefaultProcessor::process()
    references an invalid method.
    160 @covers value
    \Drupal\aggregator\Plugin\aggregator\processor\DefaultProcessor::process()
    references an invalid method.
    185 @covers value
    \Drupal\aggregator\Plugin\aggregator\processor\DefaultProcessor::process()
    references an invalid method.
    213 @covers value
    \Drupal\aggregator\Plugin\aggregator\processor\DefaultProcessor::process()
    references an invalid method.
    ------ ----------------------------------------------------------------------------
    ```

  • 🇺🇸United States dcam

    Still gotta deal with these:

     ------ --------------------------------------------------------------------- 
      Line   src/ZfExtensionManagerSfContainer.php                                
     ------ --------------------------------------------------------------------- 
      13     Class Drupal\aggregator\ZfExtensionManagerSfContainer implements     
             deprecated interface Laminas\Feed\Reader\ExtensionManagerInterface:  
             this interface is no longer needed, and shouldn't be relied upon     
      13     Class Drupal\aggregator\ZfExtensionManagerSfContainer implements     
             deprecated interface Laminas\Feed\Writer\ExtensionManagerInterface:  
             this interface is no longer needed, and shouldn't be relied upon     
      124    Fetching class constant class of deprecated class                    
             Laminas\Feed\Reader\ExtensionManagerInterface:                       
             this interface is no longer needed, and shouldn't be relied upon     
      124    Fetching class constant class of deprecated class                    
             Laminas\Feed\Writer\ExtensionManagerInterface:                       
             this interface is no longer needed, and shouldn't be relied upon     
     ------ --------------------------------------------------------------------- 
    
  • Status changed to Needs review about 1 year ago
  • First commit to issue fork.
  • Pipeline finished with Canceled
    10 months ago
    Total: 618s
    #105848
  • Pipeline finished with Success
    10 months ago
    Total: 730s
    #105857
  • 🇩🇪Germany IT-Cru Munich

    @dcam @larowlan Should issues reported by PHPCS CI job also addressed in this issue? If yes I could work down some or maybe all of them.

  • 🇺🇸United States dcam

    @IT-Cru Yes, I've only been looking at the output of GitLab CI. I'm not running it manually.

  • 🇺🇸United States dcam

    The project update bot tried to fix the same deprecations that we're dealing with in this issue. I think it's a good idea if we could finalize this one before proceeding with the D11 upgrade.

  • 🇮🇳India ankitv18

    Can we consider the $this->container->get('datetime.time') to avoid direct drupal call in the test cases also (One go sweep would be helpful for D11 upgrade)

  • 🇺🇸United States dcam

    I'll defer to @larowlan on that decision because I'm certain he's more aware of the implications than I am. But as I understand it, using $this->container can be fraught with problems. #2066993: Use \Drupal consistently in tests has lingered in the Core queue for a long time, but the trend in that discussion was to standardize on \Drupal in tests because of the multiple issues that the container has caused. I'm inclined to follow that recommendation.

  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

    $this->container should be avoided in functional tests where there's a site under test and the runner. Changes to the container in the site under test don't propogate to $this->container but do to \Drupal

  • 🇮🇳India ankitv18

    Okh but my intention for this suggestion specifically for Kernel Test that I have seen in the core too.
    Lets take a example of Drupal\KernelTests\Core\DrupalKernel or AutowireTest
    cc: @larowlan

  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

    Happy with use of it in kernel tests 👍️

  • Pipeline finished with Failed
    6 months ago
    Total: 269s
    #211529
  • Pipeline finished with Failed
    6 months ago
    Total: 3438s
    #211536
  • 🇮🇳India deepakkm

    @dcam - i think we should create a separate ticket to fix PHPCS issue as we have many changes in it and that might become complex to review and hence created a separate ticket to fix those - https://www.drupal.org/project/aggregator/issues/3458515 📌 Fix PHPCS issue reported by gitlab CI Needs work

  • Pipeline finished with Failed
    6 months ago
    #214145
  • Pipeline finished with Failed
    6 months ago
    #214148
  • Pipeline finished with Failed
    5 months ago
    Total: 202s
    #228436
  • Pipeline finished with Failed
    5 months ago
    Total: 205s
    #228442
  • Pipeline finished with Failed
    5 months ago
    #228455
  • Pipeline finished with Canceled
    5 months ago
    Total: 214s
    #228502
  • Pipeline finished with Failed
    5 months ago
    Total: 266s
    #228505
  • Pipeline finished with Failed
    5 months ago
    Total: 252s
    #228533
  • Pipeline finished with Failed
    5 months ago
    Total: 281s
    #228625
  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
  • Pipeline finished with Skipped
    5 months ago
    #243082
  • Status changed to Fixed 5 months ago
  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

    Yay finally

    Also cutting a d11 release

    And added a scheduled task so we can catch this sooner when core breaks our stuff next time

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024