Contexual links should never be bold, unless the theme explicitly makes it so

Checked and it seems like changes are working. Adding screen recording.

Unless it's failing accessibility color contrast I believe this is a won't fix.

Should be noted how this is a bug and not a personal preference though

I'm not sure what this is fixing, the issue summary reads like it was written by AI

Can we get a plain text description with before and after screenshots please

@larowlan, lol. Its sounds like an AI generated text for me too. So updating the summary to make some more sense.

@smustgrave, please see the updated summary. Some links are inheriting the font weight of its parent block. Upon checking, the fix @Nitin shrivastava provided is fixing this consistency.

It should be looked at when that color was added if it was done on purpose.

Color for all links are consistent (#333) and its declared in core/modules/contextual/css/contextual.theme.css. But font-weight is not declared in that css file. Because of that its getting inherited from its parent element, and is inconsistent depending on the blocks its showing.

Thanks, that issue summary is much nicer

Can we remove the redundant MRs, there's three so it's not clear which one is up for review

sijumpk → changed the visibility of the branch 11.x to hidden.

sijumpk → changed the visibility of the branch Nitin_shrivastava-afc07c9e-patch-7773 to hidden.

I just took a look into this issue and after spending some minutes on it. My suggestion is like this - The contextual link is working fine as it should work. The font weight is normal but the main issue is caused because the CSS was given to the secondary nav which is making all the links bolder inside the secondary nav. So we should not target the secondary nav class directly to make the links bold. Instead of targeting the secondary nav (parent class), we should target the secondary-nav__menu-link (child class) class as we did for the primary nav.

See screenshots for better understanding :)

@shweta__sharma, why should we alter styles with menu items, its upto the theme using. There is already a selector (".contextual-region .contextual .contextual-links a") present for this element in contextual.theme.css file.

@larowlan, the MR I checked is !5613, its the only pipeline passed one. And its seems like fixing the problem

It is minor but the boldness is there in olivero nav

lauriii → closed merge request !5613

Committed c2021dd and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Do we want to fix this in Stable 9 too? Any potential disruption seems unlikely enough that this could potentially be accepted there.

Automatically closed - issue fixed for 2 weeks with no activity.