- Issue created by @Gorf
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 10:26am 28 November 2023 - 🇮🇳India viren18febS
I have fixed the above issue & added patch, please review.
- Status changed to Needs work
about 1 year ago 10:46am 28 November 2023 - 🇮🇳India SandeepSingh199
@viren18febS, I reviewed #4 patch and its throwing other issue.
- 🇺🇸United States boinkster
Working though templates with the fix suggested in #7, eventually leads to:
TypeError: Unsupported operand types: null - array in __TwigTemplate_7c900ea4bd68698dd0a963aeeff08683->doDisplay() (line 47 of /var/www/html/vendor/twig/twig/src/Environment.php(361) : eval()'d code).
- 🇺🇸United States anilu@ Houston, TX
You need to remove every navbar-brand_ in utility_classes
- 🇺🇸United States boinkster
Still throws the same error after changing every navbar-brand_utility_classes to utility_classes in navbar-brand.twig
This is becoming a mess with the
utility_classes
, I have two options:
1. Make every utility class of every component named just:utility_classes
2. What we have at the moment (but fix the problem) and name:[component-name]_utility_classes
I wonder if the first option makes more sense here, any pros and cons worth sharing, love to hear what you guys think
- 🇺🇸United States boinkster
I'm new to SDC so don't have knowledge of whether
utility_classes
everywhere would be an issue down the road. - 🇺🇸United States boinkster
It's unclear to me what is happening with the twig
utility_classes
ternary statement and subsequentclasses
merge. How does a value get passed in toutility_classes
and why would you need to? - Status changed to Fixed
about 1 year ago 12:08pm 30 November 2023 Okay thank you all for helping out on this, it was a naming convention issue causing the breakdown. pushed a fix and tagged a new beta3 release.
crediting allAutomatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
12 months ago 12:27am 21 December 2023