Remove unused no stub from block content migration files

Open on Drupal.org →

Created on 24 November 2023, about 1 year ago

Updated 15 February 2024, 10 months ago

Problem/Motivation

During the migration of a 'entity:block_content' I saw that the destination plugin has the 'no_stub' parameter set to TRUE in the given examples: - https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/block...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/block...

I have searched in the code but I wasn't able to find anyplace where the 'no_stub' value is used during the block_content creation or why is it used in these files (maybe it's not necessary anymore).

Proposed resolution

Remove the 'no_stub = true' from these two files if they have no usage as they are unnecessary and might cause confusion.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated about 3 hours ago

Maintained by
🇺🇸United States @benjifisher
@heddn
🇺🇸United States @mikelutz
🇳🇿New Zealand @quietone

Created by

🇪🇸Spain miguelarber

Live updates comments and jobs are added and updated live.

migration

Needs subsystem maintainer review
It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Incomplete comments

Sign in to follow issues

Merge Requests

!5539Remove unused no stub from block content migration files
Open
🇪🇸Spain miguelarber
updated about 1 year ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Issue created by @miguelarber
Merge request !5539Resolve #3404022 "Remove unused no" → (Open) created by miguelarber
Comment about 1 year ago →
🇪🇸Spain miguelarber
Attached to this comment is the patch for Drupal 10.1.x.
Status changed to Needs review about 1 year ago4:59am 28 November 2023
Comment about 1 year ago →
🇮🇳India viren18febS
Status changed to Needs work about 1 year ago2:23pm 28 November 2023
Comment 10 months ago →
🇺🇸United States benjifisher Boston area
For purposes of this issue, we should probably add a test that will fail if the no_stub configuration is removed from these migrations.

I think we should also add documentation for how it works currently. For instance, the doc block for the migration_lookup plugin should mention that the candidates for stub migration might not be willing to serve. And Migration documents its definition keys, including destination. It should also document the no_stub option there.

Then we can move the discussion of whether to deprecate this feature to #3247754: [PP-1] Remove use of MigrateSkipRowException from core process plugins → and related issues.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024