- Issue created by @Nitin shrivastava
- Status changed to Needs review
about 1 year ago 7:26am 22 November 2023 - 🇮🇳India swatidhurandhar
Hi @Nitin shrivastava I have added a patch for the requested feature. Please review and let me know if the background color which I have added needs to be changed.
Thanks - 🇮🇳India Nitin shrivastava
@swatidhurandhar the patch has been successfully applied. I believe we should incorporate border-width and color adjustments aligned with the message and error divs. I've already updated the patch accordingly.
Regarding my suggestion, it might be beneficial to remove the .layout-builder class from this section. Doing so would allow for a more universal application, enhancing the overall appearance.
- Status changed to Needs work
about 1 year ago 8:24am 22 November 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
about 1 year ago 4:13pm 25 November 2023 - 🇺🇸United States smustgrave
Think this will need sign off from claro maintainer to see if something that wants to be added.
- Status changed to Postponed: needs info
about 1 year ago 5:31pm 30 November 2023 - 🇺🇸United States smustgrave
So question what problem is this solving, is the background causing a color contrast issue? If so could those results be posted
If this is a personal change could you provide the "why" this is better please?
Thanks!