- Issue created by @simohell
- Merge request !5497Remove aria-pressed attribute from details in favor of aria-expanded → (Closed) created by simohell
- Status changed to Needs review
about 1 year ago 5:14pm 21 November 2023 - Status changed to Needs work
about 1 year ago 6:28pm 21 November 2023 - 🇨🇦Canada mgifford Ottawa, Ontario
Looking at some recent examples, including Scott's above, I'm not sure that we need any aria for the detail/summary. There was an outstanding bug for NVDA, but I think that's been resolved now.
Some follow-up links:
- https://blog.learningtoo.eu/expanding-summary-details-accessibly
- https://dequeuniversity.com/library/aria/expand-collapse-summary
- https://www.hassellinclusion.com/blog/accessible-accordions-part-2-using...
- https://developer.mozilla.org/en-US/docs/Web/HTML/Element/summary
Wouldn't it be nice if we could just get it down to very basic HTML -
<summary class="claro-details__summary">
- Status changed to Needs review
about 1 year ago 11:03pm 21 November 2023 - 🇫🇮Finland simohell
Dropped testing for the attribute that got removed.
- Status changed to RTBC
about 1 year ago 1:51am 22 November 2023 - 🇺🇸United States smustgrave
Taking #5 as accessibility sign off then :)
- 🇺🇸United States itmaybejj
Oh splendid. I have an open ticket to remove this attribute from our themes, as it confuses VoiceOver into announcing the summary/details as if it is a form element rather than a fieldset.
This will do nicely.
- 🇳🇿New Zealand quietone
I'm triaging RTBC issues → . I read the IS, the comments and the MR. I didn't find any unanswered questions or other work to do.
There is support for this change from an Accessibility topic maintainer, #5.
Leaving at RTBC.
- 🇬🇧United Kingdom longwave UK
Agree that from reading the docs
aria-pressed
indicates the pressed state of a toggle button, and while<details>
could be considered a toggle button, the value ofaria-expanded
would seem to have more relevance. As these are always the same value then removingaria-pressed
makes sense.Backporting to 10.2.x as an accessibility fix.
Committed and pushed 91a743c141 to 11.x and 5d5a43b86f to 10.2.x. Thanks!
-
longwave →
committed 5d5a43b8 on 10.2.x
Issue #3403198 by simohell, mgifford, itmaybejj: Details do not benefit...
-
longwave →
committed 5d5a43b8 on 10.2.x
- Status changed to Fixed
10 months ago 3:43pm 17 February 2024 -
longwave →
committed 91a743c1 on 11.x
Issue #3403198 by simohell, mgifford, itmaybejj: Details do not benefit...
-
longwave →
committed 91a743c1 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.