- Issue created by @chancenyasulu
- Status changed to Needs review
over 1 year ago 5:40am 22 November 2023 - Status changed to Needs work
over 1 year ago 6:49pm 22 November 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
A summary must describe what needs to be changed, and eventually why. A screenshot is not sufficient, even in the case a patch/MR is provided.
In the case of bug reports, the steps to reproduce the bug should be provided too. In the case of coding standards issues found using an automatic tool, the report given by that tool must be quoted too, including the arguments passed to that tool, if it is a command line tool. - Status changed to Needs review
over 1 year ago 4:45am 23 November 2023 - 🇮🇳India sijumpk
There are not much details provided about the command used for getting the results in the issue description. It seems like PHP CodeSniffer is used (from the issue title) for generating it. Any way all these warnings and errors were present when I checked with phpcs using Drupal and DrupalPractice as standards. Those are all fixed (and some more) and committed to the repository. In order to test it, one can use the following command. Now its returning an empty result.
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig responsive_views_pager/*
- First commit to issue fork.
- thakurnishant_06 India
Hi @sijumpk,
I have reviewed the module by cloning the issue fork and running the PHPCS command. It appears that all the previous errors and warnings reported by the code sniffer have been addressed; however, some errors still persist.svinfotech1@svinfotech1:/opt/lampp/htdocs/testing$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/responsive_views_pager-3403133/ FILE: .../modules/responsive_views_pager-3403133/src/Plugin/views/pager/Dynamic.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 136 | ERROR | The array declaration extends to column 88 (the limit is 80). | | The array content should be split up over multiple lines 149 | ERROR | The array declaration extends to column 84 (the limit is 80). | | The array content should be split up over multiple lines -------------------------------------------------------------------------------- Time: 1.21 secs; Memory: 10MB
Thank you.
- Status changed to Fixed
over 1 year ago 11:54am 23 November 2023 - Status changed to Fixed
over 1 year ago 4:51am 24 November 2023 - Status changed to Fixed
over 1 year ago 9:19am 24 November 2023 - Status changed to Fixed
over 1 year ago 11:49am 27 November 2023