Removal of @internal tag from Drupal\media\Plugin\Field\FieldFormatter\OEmbedFormatter and Drupal\user\ProfileForm.

+1 to this issue. Noticed these warnings for the module in upgrade status reports (For ref: #3380177)

Raised an MR for the same.

Before fix:

After fix:

Thanks!

This doesn't prevent using them on D10

It just warns that you're building on shifting sands

True. Not a blocker at all as we are able to use the module. But had come across such similar instance #3256539: Remove @internal from ContentEntityDeleteForm generic base class → where we removed the @internal tag from a class that was being extended. Hence the MR.
Please suggest, if such warnings can be ignored.

Thank you!

Seems something that should get submaintainer sign off.

I don't think this should be committed as-is.

First of all...it's affecting two different, completely unrelated classes in two different modules. What is the rationale for that?

More importantly, there are real reasons why these classes are internal. They are not meant to be heavily extended - code that does it is playing a dangerous game and courting sudden breakage, as @larowlan points out.

As @ankithashetty points out, this is not actually blocking anything -- it sounds like it's just to remove IDE warnings. The IDE is right to warn about extending (or even touching) internal classes, but you can either copy the classes wholesale into your own module(s) if you need to customize them, or ignore the warnings entirely if you're not concerned about them.

So, my impulse is to close this issue as "won't fix" - leaving that for someone else, though, in case I'm missing something. :)

Going to put into PNMI for an answer to above. If not we can close out.

You can use the module

It's just that phpstan and upgrade status are warning you that things might change in the future without a BC layer

If you have test coverage for the functionality, then you're ok

Removing the internal tag is not the solution