- Issue created by @catch
- Status changed to Needs review
over 1 year ago 6:37pm 14 November 2023 - 🇮🇳India pradhumanjainOSL
Replace assertWaitOnAjaxRequest with assertExpectedAjaxRequest
and add the deprecation warning in assertWaitOnAjaxRequest method.
Please review. - Status changed to Needs work
over 1 year ago 6:45pm 14 November 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Postponed
over 1 year ago 8:43pm 14 November 2023 - 🇬🇧United Kingdom catch
The changes look mostly fine. This actually requires 📌 Stabilize FunctionalJavascript testing AJAX: add ::assertExpectedAjaxRequest() Fixed to land first, I should have marked it postponed on that and doing so now.
For the new deprecation, it should be from 10.2.0 instead of 10.1.0
- Status changed to Active
8 months ago 7:15am 3 August 2024 - Assigned to ankitv18
- 🇺🇸United States nafisb
I'm Nafis at DrupalCon Atlanta. I plan on working on this issue for the rest of the day.
- Merge request !11663Draft: Deprecate `assertWaitOnAjaxRequest` method in JSWebAssert in favor of `assertExpectedAjaxRequest` → (Open) created by Unnamed author
- 🇺🇸United States nafisb
nafisb → changed the visibility of the branch 3401619-deprecate-assertwaitonajaxrequest-rebased to hidden.
- 🇺🇸United States nafisb
nafisb → changed the visibility of the branch 3401619-deprecate-assertwaitonajaxrequest-rebased to active.
- Merge request !1Draft: Deprecate `assertWaitOnAjaxRequest` test method → (Open) created by Unnamed author