- Issue created by @catch
- Status changed to Needs review
about 1 year ago 10:07am 11 December 2023 - π¬π§United Kingdom catch
Moving to needs review.
Assuming we go ahead with this plan, we should open a postponed issue and remove the old database updates as close as possible to the 10.3 beta, to minimize the chances of having to regenerate database dumps multiple times since that's still time consuming and error prone. On the other hand if we're able to get π Rework database update tests so we don't have to ship database dumps in git Active done it might then be easier to remove updates on a rolling basis.
- πΊπΈUnited States smustgrave
By getting all sites onto 10.3 before they do the major upgrade, it also helps to get sites updated to the latest contrib versions as well (indirectly), and there will be much better 11.x compatibility amongst contrib modules when 10.3 is out.
I like this part.
- Status changed to RTBC
12 months ago 1:44am 27 December 2023 - πΊπΈUnited States smustgrave
Been about a week but no one has openly objected. Want me to open the followup mentioned in #3?
- π¬π§United Kingdom catch
This could use a +1 from a release manager who's not me still I think, tagging for that.
- Status changed to Needs review
11 months ago 2:37pm 19 January 2024 - ππΊHungary GΓ‘bor Hojtsy Hungary
Now that Drupal 10 will be supported until the Drupal 12 is released, would it not be in line with that intent to keep the update functions instead? I understand that removing the upgrade functions is standard practice, but https://www.drupal.org/blog/drupal-10-will-be-supported-until-the-releas... β would be counter to that?
- π¬π§United Kingdom catch
There are three reasons to remove older update functions:
1. To encourage sites to update contributed modules to 11.x-compatible versions before updating core to 11.x. i.e. sites on 10.3.x with updated contrib module are much more likely to update to 11.0.x successfully than sites on 10.0.0 trying to jump all the way to 11.x and updating their contrib modules at the same time. They probably won't be able to update contrib modules running 10.0.0 because they may rely on new APIs added in 10.1 to 10.3.
2. To minimize the number of (core and contrib) update functions that can potentially have to run in the same update, for example if a site tried to update all the way from 10.0.0 to 11.6.0 (which would represent 4-5 years of core development) there could be tens of updates that need to run, config that gets updated multiple times for different changes etc. The more updates can potentially run, the more likely it is that we end up with dependency issues where update X has to run before update Y but after update Z and similar.
3. To reduce the matrix of update paths that we don't have test coverage for. e.g. ideally we'd have test coverage for 10.3-11.0, 10.4-11.0, 10.5-11.0, 10.3-11.1, 10.4-11.1, 10.5-11.1, 11.0-11.1 etc. but we don't have anything like that and can't add it with the current update test infrastructure.
I think that #1 is about the same with 10-11 as it was for 9-10. But #2 and #3 will actually be worse with two active branches, since we'll have more total minor releases to juggle, more updates paths to potentially backport between major versions (or not), and more potential paths to for people to take between different combinations of versions.
Or tl;dr, we've said that 10.x will be supported until Drupal 12.0, but we didn't say that Drupal 10.0 will be supported until 12.0.
- Status changed to RTBC
11 months ago 3:30pm 24 January 2024 - πΊπΈUnited States smustgrave
Not a release manager but believe this can be back in RTBC.
- π¬π§United Kingdom catch
fwiw I discussed #7 briefly with GΓ‘bor in slack and we realised that removing updates from 10.0-10.3 from 11.x doesn't preclude updating from Drupal >= 10.3 to 12.0.
That will depend on the functions added from 10.4/11.0 onwards and when those get removed. e.g. there could be a situation where you can update from 10.6 and 11.4 to 12.0, but not from 10.5 and 11.3. Or it could be that you can update only from 11.4+ to 12.0 - it all depends what gets backported to Drupal 10 minor releases, and what the cut-off point is. This doesn't automatically mean we'll support a Drupal 10-12 update path, but it adds an extra thing to think about in π± [policy, no patch] Remove old update hooks prior to each major version (Drupal 10 and later) Needs review and is unaffected by this issue.
What this issue will do is prevent direct updates from Drupal 9.5-10.2 to Drupal 11.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
+1 from me. We're telling people they can jump from LTS to LTS so we'd expect people to be on 10.4 and stay there until 11.4 (assuming that's the LTS) comes out. This is like how Ubuntu users go from 20.4 to 22.4 and skip the non LTS versions in the middle
- π³πΏNew Zealand quietone
I agree with this as well. I must admit I am fond of the reduced workload part regarding the dumps.
- Status changed to Fixed
11 months ago 11:10am 25 January 2024 - π¬π§United Kingdom catch
I've updated π± [policy, no patch] Remove old update hooks prior to each major version (Drupal 10 and later) Needs review quoting/linking some of the discussion here. Now that this has had an additional +1 from another release manager, going to mark it fixed. Have also opened π [11.x] [PP-x] Remove updates added up until 10.3.0 from Drupal 11 Active for the implementation issue.
Automatically closed - issue fixed for 2 weeks with no activity.