- Issue created by @Spokje
- @spokje opened merge request.
- Status changed to Needs review
10 months ago 5:58pm 12 November 2023 - Status changed to RTBC
10 months ago 2:44pm 13 November 2023 - πΊπΈUnited States smustgrave
Seems fine to me.
Would love to know why nightwatch is failing so frequently in gitlab this last week.
- Status changed to Needs review
10 months ago 3:28pm 13 November 2023 - π¬π§United Kingdom longwave UK
Should we set
DRUPAL_NIGHTWATCH_OUTPUT
to../nightwatch_output
instead? Feels a bit wrong writing inside thecore
directory, which is part of the checkout. - π³π±Netherlands Spokje
Sure, just wanted to maintain the original setting of
DRUPAL_NIGHTWATCH_OUTPUT
. - Status changed to Needs work
10 months ago 6:38pm 13 November 2023 - π¬π§United Kingdom longwave UK
Question about the mkdir/chown lines - not sure these are needed even if it's working without it!
- Status changed to Needs review
10 months ago 7:32pm 13 November 2023 - π³π±Netherlands Spokje
I think we lost babel, along with its caching somewhere around #3278415: Remove usages of the JavaScript ES6 build step, the build step itself, and associated dev dependencies β ?
- Assigned to Spokje
- Status changed to Needs work
10 months ago 9:28am 14 November 2023 - Issue was unassigned.
- Status changed to Needs review
10 months ago 12:08pm 14 November 2023 - Assigned to Spokje
- Status changed to Needs work
10 months ago 12:33pm 14 November 2023 - Issue was unassigned.
- Status changed to Needs review
10 months ago 4:23pm 14 November 2023 - π³π±Netherlands Spokje
This seems to be the minimal mkdir-s that would be otherwise created through Drupal and the minimal chown-s to work/prevent warnings.
- π³π±Netherlands Spokje
Well, I stand corrected, all mkdir-s are not needed.
- Status changed to RTBC
10 months ago 2:53pm 15 November 2023 - πΊπΈUnited States smustgrave
Leaning on this didn't break anything it seems and am seeing artifacts here https://git.drupalcode.org/issue/drupal-3401102/-/jobs/335835/artifacts/...
- π¬π§United Kingdom longwave UK
Also seeing Nightwatch results now at https://git.drupalcode.org/issue/drupal-3401102/-/pipelines/50024/test_r...
Great work!
-
longwave β
committed b71596d0 on 10.2.x
Issue #3401102 by Spokje, longwave, smustgrave: Nightwatch artifacts on...
-
longwave β
committed b71596d0 on 10.2.x
-
longwave β
committed 93eb2340 on 11.x
Issue #3401102 by Spokje, longwave, smustgrave: Nightwatch artifacts on...
-
longwave β
committed 93eb2340 on 11.x
-
longwave β
committed 5e1bfe3a on 10.1.x
Issue #3401102 by Spokje, longwave, smustgrave: Nightwatch artifacts on...
-
longwave β
committed 5e1bfe3a on 10.1.x
- Status changed to Fixed
10 months ago 3:09pm 15 November 2023 - π¬π§United Kingdom longwave UK
Committed and pushed 93eb23400e to 11.x and b71596d090 to 10.2.x. Thanks!
I wasn't expecting it to backport cleanly to 10.1.x, but it did, so cherry-picked it there too.
Automatically closed - issue fixed for 2 weeks with no activity.