Make PHP 8.3 the default environment for gitlab CI runs

8.3.0 release coming in 2 weeks https://wiki.php.net/todo/php83

CI images already upgraded to RC6 https://git.drupalcode.org/project/drupalci_environments/-/commit/917c45...

8.3 stable is out, so we should definitely do this on the 11.x (to also become 10.3.x) branch. 10.2 can stay on PHP 8.2 as the default I think.

Created MR for review

Also set 8.3 as default for composer/lint jobs

I bet it needs follow-up to increase \Drupal::RECOMMENDED_PHP later

8.3 seemed to run fine so marking it as that's all the ticket said.

But could we still have it run against 8.2 for a while? Doubt most people are running to 8.3 on actual projects just yet.

@smustgrave 10.2 will keep running 8.2 as the default job, so every cherry-pick to that branch will get tested. We also have all the other on-commit and scheduled jobs too going back to PHP 8.1

Needs rebase following 📌 Run child jobs in sequence? Fixed

I think it would be fine to schedule this for after the 10.2.0 release or early in the new year so that it's only getting patch cherry-picks and we potentially have less gitlab changes to make.

rebased and fixed

So this shouldn't be merged until 10.2.0 is out or does the rc1 count?

Updating the title to reflect #12

Can't we just go ahead now since the last patch release of 10.1 has already been created?

@xjm this is more about backports of gitlab YAML changes between 11.x and 10.2.x.

10.1.x was already very out of sync to the point we were unable to backport a lot of gitlab improvements to that branch due to merge conflicts. Once we make this change, it'll be harder to backport gitlab changes to 10.2 too.

Probably doesn't matter that much since at this point 10.2 will only get on-commit and scheduled runs most of the time and is unlikely to be an MR target, but since we're already running PHP 8.3 on commit a small delay seemed worth it to keep things in sync.

Once we require PHP 8.3 in 11.x, we'll have to do this then and also remove all the older PHP versions from the YAML, so it'll massively diverge at that point anyway I guess.

Still no hurry here IMO but we're officially after 10.2.0 so re-titling.

FYI release of PHP 8.3.1 this week

There is now also an RC ready for 8.3.2, so I guess it won't take ages before we see that one land as well.

So we're still waiting on the Drupal 10.3.x branch here, correct?

minimized amount of changes in MR

So we're still waiting on the Drupal 10.3.x branch here, correct?

We can commit it to 11.x and not 10.2.x, and then 11.x will also become 10.3.x later, so it's not blocked on branching. It's just a question of making gitlab harder.

I guess we can do that then to move forward with 📌 [11.x] [PP-1] Add PHP 8.3 requirement to Drupal 11.0.x Postponed ?

Also checked the latest changes in the MR and still looks good!

I am a bit confused about the chaining of the on-commit and daily runs, but let's see what happens when this is committed.

Committed aec5864 and pushed to 11.x. Thanks!

I think this broke HEAD, reverted for now: https://git.drupalcode.org/project/drupal/-/pipelines/76250

We are dropping PHP 8.2 and below for Drupal 11, so let's just remove that here.

Opened a new MR that drops support for PHP 8.1 and 8.2 in 11.x pipelines.

The "needs" chains are quite annoying and difficult to get right, do we strictly need them? Is there a better way?

We added them so that on-commit and daily pipelines would run one environment at a time instead of all at once, meaning that (hopefully) the same runners/pods can be used for the entire pipeline rather than having to start enough pods to run 5-10 environments at once.

andypost → closed merge request !5590

Removal of previous PHP will help to backport changes from 10.x

Committed/pushed to 11.x, thanks!

I think we should also make 8.3 the default environment on the 10.3 branch, 10.2 will still run against 8.2 on commit, so marking for backport there.

catch → closed merge request !6930

Changed 10.3.x to run on PHP 8.3 by default, rearranged the "needs" chains to fit.

The various jobs on https://git.drupalcode.org/project/drupal/-/pipelines/113668 all look good, which is about as much as we're going to see without committing this.

Committed d8b80ec and pushed to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.