- Issue created by @Nitin shrivastava
- Status changed to Needs review
4 months ago 11:37am 19 February 2024 - 🇮🇳India Hamid.ali
Updated the Twitter icon to the latest 'X' attaching the screenshot below:
- Status changed to Needs work
3 months ago 4:19pm 26 March 2024 Verified #2 patch on 9.5.x, the Twitter icon is updated but if we add the Twitter value it again shows as an old icon ->
Administration> Appearance >Appearance settings> Social Profiles> Twitter- Assigned to sourojeetpaul
- Status changed to Active
3 months ago 9:03am 28 March 2024 - Issue was unassigned.
- Status changed to Needs review
3 months ago 9:25am 28 March 2024 Hello Tanuja,
The issue you were facing even after applying the patch is because, although the CDN is correctly updated to the latest version, the twitter logo needs to be updated in both the files i.e social-icons.html.twig and social-icons-empty.html.twig as there is a conditional rendering of that block in footer.html.twig.
I've raised an MR for the issue which addresses it by making changes on all the 3 required files. Please have a look. Hope it solves the issue!
https://git.drupalcode.org/project/electra/-/merge_requests/2
After making all the changes, now when i'm modifying Administration> Appearance >Appearance settings> Social Profiles> Twitter the twitter logo remains fixed as X.
Hi, Reviewed MR 2, successfully changes the twitter icon to new one and addresses the issue mentioned #3.
- Status changed to RTBC
27 days ago 4:37am 28 May 2024 - 🇮🇳India Vivek Panicker Kolkata
As @bindu has already tested this issue and mentioned it's fine, moving this issue to RTBC.