[random test failure] TimestampFormatterWithTimeDiffTest::testTimestampFormatterWithTimeDiff

Postponed on 📌 Skip TimestampFormatterWithTimeDiffTest::testTimestampFormatterWithTimeDiff due to random fails Needs review

Adding what this is postponed on to the remaining tasks per Remining tasks → .

Should probably skip and fix all the TimeDiffViewsTests doing these sort of assertions. They're all failing like this it seems.

TimestampFormatterWithTimeDiffViewsTest::testTimestampFormatterWithTimeDiff is failing too: #3401720

The skip is committed.

There is a flaw in the logic of waiting 1001 ms for the condition to become true. The comment reads:

// Wait at least 1 second + 1 millisecond to make sure that the last time
// difference value has been refreshed.

And then we call $this->assertJsCondition(); with a timeout of 1001 ms.

But that's not how the wait function works. The wait function tests if the condition is true, then sleeps for 10000 µs (10 milliseconds). After sleeping, it checks if the timeout has passed. If not, it tests the condition again.

So imagine the time is 16:20:00.000 and we wait for 1001 ms. The wait function tests at 16:20:00.999, the condition is still false so it sleeps for 10 ms. It's now 16:20:01.009 which is after the 1001ms timeout so it doesn't test again.

I think we can simply adjust the timeout to 2000 ms and it should work.

Appears to be green, added solution the summary.

Nice find.

Committed/pushed to 11.x, thanks!

catch → closed merge request !11563

Automatically closed - issue fixed for 2 weeks with no activity.