Migrate exception message should give the index of the process plugin in the pipeline

Quick fix, not sure about the message format!

Seemed to have caused some test failures.

Have not reviewed.

Akhil Babu → made their first commit to this issue’s fork.

Tests were failing due to mismatch in message after the change. Updated them.

Few more tests should be updated

There is a strange Functionaljavscript test failure as well.

   1) Drupal\FunctionalJavascriptTests\Ajax\AjaxTest::testAjaxFocus
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'edit-textfield-2'
    +'edit-textfield-3'

Pipeline fixed after rebase. Moving to needs review

For good practice we should have a complete issue summary.

I updated the issue summary.

🐛 Exception message in subprocess doesn't say which property in the subprocess was affected Needs work may be a duplicate. It's about exception messages produced by subprocess pipelines. But this issue adds indexes to subprocess pipelines too.

I am not sure how useful this change would be. I guess that @joachim ran into a situation where it would help. The code change is pretty simple, so I do not object to making the change.

@joachim, can you share the process pipeline you were debugging when you created this issue? It would help to provide context.

Since the process pipeline is an array, maybe it would be more suggestive to use brackets instead of parentheses. For example, using a line from one of the tests in the MR:

"d7_field:type:process_field(1): Can't migrate field 'field_event' with 'todate' settings. Enable the datetime_range module. See https://www.drupal.org/docs/8/upgrade/known-issues-when-upgrading-from-drupal-6-or-7-to-drupal-8#datetime"

What do you think of this instead?

"d7_field:type:process_field[1]: Can't migrate field 'field_event' with 'todate' settings. Enable the datetime_range module. See https://www.drupal.org/docs/8/upgrade/known-issues-when-upgrading-from-drupal-6-or-7-to-drupal-8#datetime"

I also made two small suggestions on the MR.

Sorry, it was 2 years ago at a firm I'm no longer with.

My best guess is that I had some array processing or extracting process plugin twice in the same pipeline.

Since the process pipeline is an array, maybe it would be more suggestive to use brackets instead of parentheses. For example, using a line from one of the tests in the MR:

"d7_field:type:process_field(1): Can't migrate field 'field_event' with 'todate' settings. Enable the datetime_range module. See https://www.drupal.org/docs/8/upgrade/known-issues-when-upgrading-from-drupal-6-or-7-to-drupal-8#datetime"
What do you think of this instead?

"d7_field:type:process_field[1]: Can't migrate field 'field_event' with 'todate' settings. Enable the datetime_range module. See https://www.drupal.org/docs/8/upgrade/known-issues-when-upgrading-from-drupal-6-or-7-to-drupal-8#datetime"

It's a shame how difficult it would be, given how we build up that message, but

"d7_field:type[3]:process_field: Can't migrate field 'field_event' with 'todate' settings. Enable the datetime_range module. See https://www.drupal.org/docs/8/upgrade/known-issues-when-upgrading-from-drupal-6-or-7-to-drupal-8#datetime"

Would be much better. It's not the third call to a process_field plugin, it's the third process plugin called for the type destination property.

But to do it you would have to add another property to migrate exception, and bubble the value up, set it in the right places, deal with the times a migrate exception is thrown when an index makes no sense, ect.