- Issue created by @ressa
- Status changed to Postponed: needs info
about 1 year ago 9:57pm 6 November 2023 - πΊπΈUnited States drumm NY, US
Update the aggregator module to prevent this?
This is something that should be fixed in Drupal core. What are the steps to reproduce the issue? What exactly in the feed's XML is changing for every item?
- π©π°Denmark ressa Copenhagen
It happened again today, 10 old posts from TEN7 at the top.
Maybe @apaderno has an opinion about this, since he often takes care of Planet Drupal applications?
- Status changed to Active
about 1 year ago 1:32pm 19 November 2023 - π©π°Denmark ressa Copenhagen
... and again. The entire first page of Drupal Planet is taken over by Gbyte with old posts.
Setting to "Active" since I don't know how to debug this, but it's important to get fixed, and having it as Postponed will easily make it be overlooked.
- π©πͺGermany gbyte Berlin
I did update gbyte.dev from D9 to D10 yesterday so this is definitely a good hunch. I'll take a look as soon as I find the time. I take it there is no need to take any immediate action from my side?
- π©π°Denmark ressa Copenhagen
Thanks for a fast reply and confirming the "after updating to D10"-hunch, which then seems confirmed. I have created π Clean up Drupal Planet for old posts Active , so that part is taken care of.
If you have any idea how to fix this in Aggregator for a permanent fix, that would be nice :)
- πΊπΈUnited States dave reid Nebraska USA
This is a core bug in Drupal 10, let me find it.
- πΊπΈUnited States dave reid Nebraska USA
π Views RSS Feed Fields adds tag. Active is the core bug causing this
- π©π°Denmark ressa Copenhagen
Thanks for the link @Dave Reid. Do you think Aggregator in Drupal 7 should be updated to be able to handle malformed tags in this issue, or should it get fixed in that other issue?
- πΈπ°Slovakia poker10
If the problem is that in the
pubDate
element is an additional markup that violates the RSS specification:<pubDate><time datetime="2023-08-10T13:43:13-07:00" class="datetime">Thu, 10 Aug 2023 13:43:13 -0700</time></pubDate>
Then I think this needs to be fixed on the
views
side, not in theaggregator
module. Aggregator module has a fallback, that uses current date in case no valid date is provided:// Try to resolve and parse the item's publication date. $date = ''; foreach (array('pubdate', 'dc:date', 'dcterms:issued', 'dcterms:created', 'dcterms:modified', 'issued', 'created', 'modified', 'published', 'updated') as $key) { if (!empty($item[$key])) { $date = $item[$key]; break; } } $item['timestamp'] = strtotime($date);
I do not think it would be good to change this logic in this D7 phase.
- πΊπΈUnited States drumm NY, US
Link to the spec - https://www.rssboard.org/rss-specification#ltpubdategtSubelementOfLtitemgt
So it looks like the
<time>
element was introduced at some time. Following the git blame from https://git.drupalcode.org/project/drupal/-/blob/7cb99a11aca57643e8d66fc... looks like that code has been functionally unchanged for many years. The date field rendering it uses likely introduced the extra element. - π©π°Denmark ressa Copenhagen
Ten more today, added to the list. Also, making it a child issue of π Views RSS Feed Fields adds tag. Active , since fixing that would also stop Drupal Planet from getting flooded.
- Status changed to Closed: duplicate
about 1 year ago 6:00pm 28 November 2023