Contrib.social
Created on 1 November 2023, over 1 year ago
Updated 12 April 2024, about 1 year ago

Problem/Motivation

Fix code style

FILE: /var/www/html/web/modules/custom/homebox/src/Controller/HomeboxController.php
----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------
  68 | WARNING | Line exceeds 80 characters; contains 114 characters
 158 | ERROR   | Parameter $user is not described in comment
 163 | ERROR   | Doc comment for parameter $owner does not match actual variable name $user
 167 | WARNING | Line exceeds 80 characters; contains 114 characters
 227 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 257 | WARNING | Line exceeds 80 characters; contains 94 characters
----------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Controller/HomeboxTypeController.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
 44 | ERROR   | Missing parameter comment
 47 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Element/HomeboxButton.php
-----------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------
  8 | ERROR | Doc comment short description must start with a capital letter
  8 | ERROR | Doc comment short description must end with a full stop
 24 | ERROR | Doc comment is empty
-----------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Form/HomeboxPortletAddForm.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------
  51 | WARNING | Line exceeds 80 characters; contains 111 characters
 161 | WARNING | Exceptions should not be translated
 225 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 249 | WARNING | Exceptions should not be translated
----------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Form/HomeboxSubformState.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 70 | ERROR | Description for the @return value is missing
-------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Form/HomeboxSettingsForm.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 120 | WARNING | Unused variable $position.
-------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/HomeboxPortletTypePluginManager.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 45 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Entity/Homebox.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
 178 | ERROR   | Doc comment is empty
 410 | WARNING | Unused variable $key.
----------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Entity/HomeboxType.php
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------
 244 | WARNING | Line exceeds 80 characters; contains 81 characters
-------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/ThirdPartyConfigurationInterface.php
----------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
 55 | ERROR | Parameter tags must be defined first in a doc comment
 72 | ERROR | Parameter tags must be defined first in a doc comment
 87 | ERROR | Parameter tags must be defined first in a doc comment
----------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/HomeboxPortletTypeBase.php
------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------
 448 | ERROR   | Description for the @return value is missing
 572 | WARNING | Exceptions should not be translated
 601 | WARNING | Exceptions should not be translated
 630 | WARNING | Exceptions should not be translated
------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/Field/FieldType/PortletItem.php
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
 101 | ERROR | Description for the @return value is missing
-----------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/Field/FieldWidget/PortletWidget.php
---------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------
 207 | WARNING | Line exceeds 80 characters; contains 111 characters
 209 | WARNING | Line exceeds 80 characters; contains 89 characters
 218 | ERROR   | Missing parameter comment
 220 | ERROR   | Description for the @return value is missing
---------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/HomeboxPortletTypeInterface.php
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------
  16 | WARNING | There must be no blank line following an inline comment
  21 | ERROR   | Description for the @return value is missing
 129 | ERROR   | Description for the @return value is missing
-----------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/src/HomeboxViewBuilder.php
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
 259 | ERROR | Doc comment is empty
-------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/homebox.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 119 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/homebox/modules/homebox_portlet_type_block/src/Plugin/HomeboxPortletType/HomeboxPortletTypeBlock.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
 100 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 152 | WARNING | Line exceeds 80 characters; contains 90 characters
 198 | ERROR   | Parameter $account is not described in comment
-------------------------------------------------------------------------------------------------------------------------------------------

Time: 884ms; Memory: 10MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Closed: duplicate

Version

3.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Anybody
  • Merge request !25PHPCBF automatic fixes → (Open) created by Anybody
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    Manual fixes TBD

  • Issue was unassigned.
  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica
  • Comment over 1 year ago →
    🇮🇳India chetan 11

    chetan 11 → made their first commit to this issue’s fork.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • @chetan-11 opened merge request.
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    Nice work @chetan 11, hope you learned some new things. I left several comments to solve.
    Thanks you!

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India chetan 11

    Hi
    I have fixed the given comment issues, please check once.
    Thanks

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thanks @chetan 11 looks like it needs a rebase now?

  • Comment over 1 year ago →
    🇮🇳India chetan 11

    I think rebase is not required.

  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    @chetan 11 the CI thinks different, see https://git.drupalcode.org/project/homebox/-/merge_requests/26 ;)

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Comment over 1 year ago →
    thakurnishant_06 India

    Rebased the MR6

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    thakurnishant_06 India

    Kindly review changes.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Checkout Error
  • Comment over 1 year ago →
    thakurnishant_06 India

    Kindly Review.

  • Assigned to Grevil
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    FILE: /var/www/html/web/modules/custom/homebox/src/Controller/HomeboxController.php
    ----------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------
    201 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    ----------------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Controller/HomeboxTypeController.php
    ---------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------
    48 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    ---------------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Element/HomeboxButton.php
    -----------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 2 LINES
    -----------------------------------------------------------------------------
    8 | ERROR | Doc comment short description must start with a capital letter
    8 | ERROR | Doc comment short description must end with a full stop
    24 | ERROR | Doc comment is empty
    -----------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Form/HomeboxTypeForm.php
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------
    357 | WARNING | Line exceeds 80 characters; contains 81 characters
    ---------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Form/HomeboxPortletAddForm.php
    ----------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    ----------------------------------------------------------------------------------------------
    166 | WARNING | Exceptions should not be translated
    230 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    254 | WARNING | Exceptions should not be translated
    ----------------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Form/HomeboxSubformState.php
    -------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------
    70 | ERROR | Description for the @return value is missing
    -------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Form/HomeboxSettingsForm.php
    -------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------
    120 | WARNING | Unused variable $position.
    -------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/HomeboxPortletTypePluginManager.php
    --------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------------
    45 | ERROR | Description for the @return value is missing
    --------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Entity/HomeboxType.php
    -------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------
    244 | WARNING | Line exceeds 80 characters; contains 81 characters
    -------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/ThirdPartyConfigurationInterface.php
    ----------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    ----------------------------------------------------------------------------------------------
    55 | ERROR | Parameter tags must be defined first in a doc comment
    72 | ERROR | Parameter tags must be defined first in a doc comment
    87 | ERROR | Parameter tags must be defined first in a doc comment
    ----------------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/HomeboxPortletTypeBase.php
    ------------------------------------------------------------------------------------
    FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
    ------------------------------------------------------------------------------------
    464 | ERROR | Description for the @return value is missing
    588 | WARNING | Exceptions should not be translated
    617 | WARNING | Exceptions should not be translated
    646 | WARNING | Exceptions should not be translated
    ------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/Field/FieldType/PortletItem.php
    -----------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------
    101 | ERROR | Description for the @return value is missing
    -----------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/Field/FieldWidget/PortletWidget.php
    ---------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
    ---------------------------------------------------------------------------------------------
    207 | WARNING | Line exceeds 80 characters; contains 111 characters
    209 | WARNING | Line exceeds 80 characters; contains 89 characters
    218 | ERROR | Missing parameter comment
    220 | ERROR | Description for the @return value is missing
    ---------------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/src/Plugin/HomeboxPortletTypeInterface.php
    -----------------------------------------------------------------------------------------
    FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
    -----------------------------------------------------------------------------------------
    17 | WARNING | There must be no blank line following an inline comment
    22 | ERROR | Description for the @return value is missing
    152 | ERROR | Description for the @return value is missing
    -----------------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/tests/src/Functional/AccessTest.php
    ----------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ----------------------------------------------------------------------------------
    565 | WARNING | Line exceeds 80 characters; contains 94 characters
    610 | WARNING | Line exceeds 80 characters; contains 103 characters
    ----------------------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/homebox.module
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------
    119 | WARNING | Line exceeds 80 characters; contains 82 characters
    ----------------------------------------------------------------------

    FILE: /var/www/html/web/modules/custom/homebox/modules/homebox_portlet_type_block/src/Plugin/HomeboxPortletType/HomeboxPortletTypeBlock.php
    -------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
    -------------------------------------------------------------------------------------------------------------------------------------------
    102 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    114 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    154 | WARNING | Line exceeds 80 characters; contains 90 characters
    200 | ERROR | Parameter $account is not described in comment
    -------------------------------------------------------------------------------------------------------------------------------------------

  • Issue was unassigned.
  • Status changed to Closed: duplicate about 1 year ago
  • Comment about 1 year ago →
    🇩🇪Germany Grevil

    This became quite a mess. Fixing it in 📌 Use dependency injection and code style issues Needs review .

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024