Deprecate file_progress_implementation() and replace with extension_loaded('uploadprogress')

CR reads well with before/after example.

Seems all 5 instances of file_progress_implementation has been replaced.

I think we can improve usage of the new API in a couple of places, and is there the need for another API method, e.g. ::isAvailable() or similar that checks that some form of upload progress is available? Then the callers don't really need to know anything about the internals.

Re: #5 Good idea! Added and implemented in a few places.

All threads do appear to be resolved. Wonder if it's too late for 10.2 though?

Updated deprecation message to 10.3.0.

I feel like I've got to ask a couple of questions...
1. Is the static cache around extension_loaded() worth it. As far as I can see the answer is no. Locally extension_loaded('uploadprogress'); is as cheap as $a = 1 + 1;.
2. Can't we just deprecate the function as replace with extension_loaded('uploadprogress'); - we only support one implementation - as far as I know there is no plan to support another.

Makes total sense.

kim.pepper → closed merge request !5179

I'm preeetty sure the Drupal.Tests.Core.DependencyInjection.YamlFileLoaderTest fail is not related to this issue.

Had to rebase to fix the test fail. Updated the issue summary, so I think we are good for reviews now.

Appears to have open threads.

Have not re-reviewed yet.

There is a second upload progress implementation that 📌 Add support for built-in PHP session upload progress Needs work is trying to add support for, although it seems tricky and may never be completed.

Personally, I would rather not implement a new API just in case another implementation could be added in the future. I have made the mistake of over-abstracting in the past.

+1 to #19 - especially when there is ✨ Upload progress using jQuery.form plugin instead of 3rd party PHP libraries Needs work which potentially removes all of this...

Another thought - if we implement 📌 Add support for built-in PHP session upload progress Needs work might it replace the uploadprogress implementation?

PECL upload progress is still supported and works on php 8+. Although it has the same limitation of not supporting fastcgi as session upload progress. Not sure if there is a reason for supporting or the other.

In any case, I think we can continue with deprecating file_progress_implementation() and replacing with extension_loaded('uploadprogress') as that is what core currently supports. If and when we add another implementation, we can create an new API then.

Addressed feedback so back to NR.

Also added a test. Not sure if we can test the extension_loaded('uploadprogress') call. I guess we'll see what the gitlab ci images have installed.

Follows up appear to have been opened and all threads resolved.

Add a couple of comments to the MR that need adddressing.

Thanks for continuing to push on this @kim.pepper - I've hopefully explained myself a bit more on the MR.

Additional feedback has been addressed.

Committed 0f7d46f and pushed to 11.x. Thanks!

Thanks! Updated the issue summary.

Automatically closed - issue fixed for 2 weeks with no activity.

kim.pepper → closed merge request !5757