- Issue created by @saschaeggi
- @saschaeggi opened merge request.
- Status changed to Needs review
over 1 year ago 10:26am 21 October 2023 - πͺπΈSpain ckrina Barcelona
As mentioned in Slack we discussed exactly that on the CSS refactor, but on mobile this region is not sticky anymore. Thatβs why we kept bottom. Happy to change it to something more useful than bottom that still applies regardless of it being sticky :)
- Status changed to Needs work
over 1 year ago 12:56pm 21 October 2023 - πͺπΈSpain ckrina Barcelona
As mentioned in Slack we discussed exactly that on the CSS refactor, but on mobile this region is not sticky anymore. Thatβs why we kept bottom. Happy to change it to something more useful than bottom that still applies regardless of it being sticky :)
- π·πΈSerbia finnsky
we have:
1. header.
2. content.
3. bottom. (for me it should be footer) - π·πΈSerbia finnsky
Yes. Semantically it will be part of NAV
But in BEM we will add
admin-toolbar__header
admin-toolbar__content
admin-toolbar__footerSimple logic imo
- π¨πSwitzerland saschaeggi Zurich
@finnsky that sounds about right π
- Status changed to Fixed
over 1 year ago 9:09am 23 October 2023 - πͺπΈSpain ckrina Barcelona
Rebased and changed the name to footer. Thanks all!
Automatically closed - issue fixed for 2 weeks with no activity.