Add validation constraints to automated_cron.settings

Created on 20 October 2023, about 1 year ago
Updated 6 March 2024, 10 months ago

Problem/Motivation

Automated cron settings have 1 property paths that are not yet validatable:

$ ./vendor/bin/drush config:inspect --filter-keys=automated_cron.settings --detail --list-constraints  --fields=key,validatability,constraints
➜  πŸ€– Analyzing…

 ---------------------------------------------------- ------------- ------------------------------------------ 
  Key                                                  Validatable   Validation constraints                    
 ---------------------------------------------------- ------------- ------------------------------------------ 
  automated_cron.settings                              75%           ValidKeys: '<infer>'                      
                                                                     RequiredKeys: '<infer>'                   
   automated_cron.settings:                            Validatable   ValidKeys: '<infer>'                      
                                                                     RequiredKeys: '<infer>'                   
   automated_cron.settings:_core                       Validatable   ValidKeys:                                
                                                                       - default_config_hash                   
                                                                     RequiredKeys: '<infer>'                   
   automated_cron.settings:_core.default_config_hash   Validatable   NotNull: {  }                             
                                                                     Regex: '/^[a-zA-Z0-9\-_]+$/'              
                                                                     Length: 43                                
                                                                     ↣ PrimitiveType: {  }                     
   automated_cron.settings:interval                    NOT           ⚠️  @todo Add validation constraints here  
 ---------------------------------------------------- ------------- ------------------------------------------ 

Steps to reproduce

  1. Get a local git clone of Drupal core 11.x.
  2. composer require drupal/config_inspector β€” or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 β†’ or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. vendor/bin/drush config:inspect --filter-keys=olivero.settings --detail --list-constraints

Proposed resolution

Add validation constraints to:

  1. interval

This requires looking at the existing code and admin UI (if any) to understand which values could be considered valid. Eventually this needs to be reviewed by the relevant subsystem maintainer.

For examples, search *.schema.yml files for the string constraints: 😊

Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.

Remaining tasks

  1. interval

User interface changes

None.

API changes

None.

Data model changes

More validation πŸš€

Release notes snippet

None.

πŸ“Œ Task
Status

Fixed

Version

11.0 πŸ”₯

Component
CronΒ  β†’

Last updated 15 days ago

No maintainer
Created by

πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024