- Issue created by @ecvandenberg
- ๐ฎ๐ณIndia sarwan
sarwan_verma โ made their first commit to this issueโs fork.
- @sarwan_verma opened merge request.
- Status changed to Needs review
9 months ago 12:06pm 13 October 2023 - ๐ฎ๐ณIndia sarwan
Hi @ecvandenberg
I have fixed the issue in MR, please review and verify .
- ๐ณ๐ฑNetherlands ecvandenberg
Thank you very much!
It seems to work fine over here.
Although I got this error:
https://www.drupal.org/project/commerce/issues/3304747 ๐ RuntimeException: Failed to start the session because headers have already been sent by Response.php Active
Not sure if this has anything to do with Mollie though...Are you able to create a patch file?
- ๐ณ๐ฑNetherlands ecvandenberg
You are lightning fast!
One problem...I think the other (related) patch is also required. But they can not apply on top of each other.
- ๐ฎ๐ณIndia sarwan
To apply both patches, check for dependencies or a specific order in which they should be installed. They might conflict or require a particular sequence for successful application.
- ๐ง๐ชBelgium kensae
I guess it would be better to keep both issues separated and remove the changes for the Mollie for Drupal Webform submodule in this patch?
I wonder If we should even include patches for Mollie for Ubercart and Mollie for Drupal - Customers API or move them to separate issues? - ๐ง๐ชBelgium DieterHolvoet Brussels
Yeah, let's keep it separate. I'll remove unnecessary changes from the issue fork.
- ๐ณ๐ฑNetherlands ricovandevin
As Mollie for Drupal 3.0 will also contain architectural changes we have decided to make 2.2 Drupal 10 compatible first.
- Status changed to Needs work
8 months ago 12:53pm 10 November 2023 - ๐ณ๐ฑNetherlands ricovandevin
Mollie for Ubercart is deprecated and will be removed in 3.x as Ubercart is not supported anymore after Drupal 8 according to the project page ( https://www.drupal.org/project/ubercart โ ).
Mollie Customers API is to be handled separately to keep things clean.
- Status changed to Fixed
8 months ago 1:22pm 10 November 2023 - ๐ณ๐ฑNetherlands ricovandevin
This fix is included in Mollie for Drupal 2.2.0. Users who already upgraded to version 3.x-dev for Drupal 10 compatibility are urged to downgrade to 2.2.0 at least until an alpha or beta version of version 3.0.0 is released. All currently published changes in 3.x-dev are included in 2.2.0 too.
-
ricovandevin โ
committed 714646ea on 2.2.x
Issue #3393906 by DieterHolvoet, kensae, ecvandenberg, ricovandevin:...
-
ricovandevin โ
committed 714646ea on 2.2.x
-
ricovandevin โ
committed 714646ea on 3.0.x
Issue #3393906 by DieterHolvoet, kensae, ecvandenberg, ricovandevin:...
-
ricovandevin โ
committed 714646ea on 3.0.x
Automatically closed - issue fixed for 2 weeks with no activity.