- Issue created by @finnsky
- First commit to issue fork.
- @vensires opened merge request.
- 🇷🇸Serbia finnsky
From my point of view this kind of change should be at least scoped in:
1. Only mobile breakpoint
2. Only tables in content area.Also probably we need to use
https://www.npmjs.com/package/tua-body-scroll-lockIt is part of core libraries. So can be useful here.
- Status changed to Needs review
over 1 year ago 12:26pm 20 October 2023 - 🇬🇷Greece vensires
@finnsky, I have just pushed what could be a solution.
Can you please review it in https://git.drupalcode.org/project/navigation/-/merge_requests/100.diff?In general, when the user has zoomed out in ex.
/admin/content
and the navigation menu gets expanded, the tables in the body get limited to the viewport's width which actually causes something like a zoom-in, though not exactly. - First commit to issue fork.
- Status changed to RTBC
over 1 year ago 3:28pm 20 October 2023 - @rfmarcelino opened merge request.
- Status changed to Needs work
over 1 year ago 3:38pm 20 October 2023 - 🇬🇷Greece vensires
Regarding point (3) we can't really find a more specific selector.
The default
/admin/content
provides the following HTML:<table class="views-table views-view-table cols-7 responsive-enabled sticky-enabled" data-once="tableresponsive table-select">
and we also have its sticky header:
<table class="sticky-header" style="visibility: hidden; position: fixed; top: 0px; left: 312px; width: 1425px;">
I would fix the mobile scope issue in a future commit.
- Status changed to Needs review
over 1 year ago 6:25am 21 October 2023 - Status changed to Needs work
over 1 year ago 6:34am 21 October 2023 - @finnsky opened merge request.
- 🇷🇸Serbia finnsky
Pushed another approach with bodyscroll Lock library from core
- Status changed to Needs review
over 1 year ago 7:46am 21 October 2023 - 🇷🇸Serbia finnsky
Overflow clip for HTML only not fixing initial issue.
But together with BODY overflow clip seems it works.Please review!
- Status changed to RTBC
over 1 year ago 9:29pm 22 October 2023 - First commit to issue fork.
- Status changed to Fixed
over 1 year ago 7:48am 23 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.