TypeError: Unsupported operand types: array + null in photoswipe_dynamic_caption_photoswipe_js_options_alter() (line 48 of modules/contrib/photoswipe/modules/photoswipe_dynamic_caption/photoswipe_dynamic_caption.module).

This needs

1. An update hook (to set the values if not yet set individually)
2. A schema.yml
3. An install config with the correct defaults

No idea why we missed that. My apologies!

@Shreya_th when can we expect your final solution?

@Anybody , just give me 5 min

None of the points in #4 have been addressd, this is just hacky. We'll do it ourselves, thanks.

"ffunction"? 😅
Also, completely wrong approach.

Anybody → closed merge request !101

This issue was introduced back when we did the Photoswipe v5 implementation in ✨ [5.x] PhotoSwipe 5 Branch Fixed . We updated the "photoswipe_dynamic_caption" view options through an update hook, but never the global options. Since photoswipe probably uses a default fallback, this issue never occurred, until the caption settings page got created through ✨ Add settings for Dynamic Caption submodule Fixed .

Fixed! Please review! Works great, drush cex output after executing the update hook:

~/myprojects/ddev-vscode-drupal/web/modules/custom/photoswipe 3392898-type…perand-types !2 ❯ ddev drush cex --diff                                                                                                             14s 15:01:18
 [notice] Differences of the active config to the export directory:
diff --git a/tmp/drush_tmp_1696942883_65254b23a4f78/photoswipe_dynamic_caption.settings.yml b/tmp/drush_tmp_1696942883_65254b23b14c5/photoswipe_dynamic_caption.settings.yml
index 826e67e..032ceb6 100644
--- a/tmp/drush_tmp_1696942883_65254b23a4f78/photoswipe_dynamic_caption.settings.yml
+++ b/tmp/drush_tmp_1696942883_65254b23b14c5/photoswipe_dynamic_caption.settings.yml
@@ -1,8 +1,8 @@
 _core:
   default_config_hash: 5Rqs8Z9MdUic8UNbjMlbp-GGT8K1jXt-FGyJhx_RjA4
 options:
-  type: null
-  mobileLayoutBreakpoint: null
-  horizontalEdgeThreshold: null
-  mobileCaptionOverlapRatio: null
-  verticallyCenterImage: null
+  type: auto
+  mobileLayoutBreakpoint: 600
+  horizontalEdgeThreshold: 20
+  mobileCaptionOverlapRatio: 0.3
+  verticallyCenterImage: false

Checking "empty($config->get('options.verticallyCenterImage'))" could be discussable (since it is boolean) but should be fine in my opinion.

Alright, tiny adjustment "photoswipe_dynamic_caption_photoswipe_js_options_alter" was incorrectly implemented, and it was possible to clear the settings, which would result in further errors.

Review now pls!

LGTM - RTBC once tests go green!

Automatically closed - issue fixed for 2 weeks with no activity.