Add settings for Dynamic Caption submodule

I will start tackling this issue now and implementing it!

Putting this into review now, basically finished and working!
In the review, please tell me if and where there is a documenting source for these settings where I can find out what they do exactly in order to fill out the missing ("???") descriptions!

@LRWebks thanks! Documentation for the settings can be found here: https://github.com/dimsemenov/photoswipe-dynamic-caption-plugin (below at around half the page height)

Added a few comments, otherwise LGTM!

See @Anybody's comment for the description.

Back to review! Added the missing descriptions and resolved all threads. @Grevil, please resolve your threads yourself, as I cannot.

Back to needs work.

Resolved all issues again, back to review!

Just had a look at the settings page and LGTM. Are all options well tested? (As there are not tests in place).

Just one UX improvement from my side:
The select texts are very long for the "Caption Position" setting.

In such a case I think it's better looking to use type "radios" instead of "select". And I'd prefer to write the options with ":" instead of the minus as separator:

• auto: Try ... [Default]

Input validations are perfect. Well done :)

@Grevil: Please do the final code review and decide if it's worth adding tests here.

PS: Please do not forget to set the comments resolved, if they are.

Please do not forget to set the comments resolved, if they are.

He can't, as he isn't a Maintainer. No idea, when they introduced this "Feature".

I did some small adjustments and removed the _options prefix from the form elements, since the introduction of validation constraints in config forms (see https://www.drupal.org/node/3373502 → ) we should always make sure, that our form elements are named after the config entry it represents. Otherwise, we need to implement "mapConfigKeyToFormElementName()", if we ever want to use validation constraints inside photoswipe:

If your form has some form elements that aren't named the same as the corresponding config key, then also override ConfigFormBase::mapConfigKeyToFormElementName():

Once tests pass, we can merge this! :)

4 failing tests

Fixed, please rereview.

Great work all! Merged! :)

Automatically closed - issue fixed for 2 weeks with no activity.