CKEDITOR5: Not able to use the Link info , Advanced, and Target tabs.

Created on 9 October 2023, over 1 year ago
Updated 22 May 2024, 11 months ago

Problem/Motivation

I am not able to use the Link info , Advanced, and Target tabs availabe in CKE4 . The tabs appear as a popup when a user click on link as , but in ckeditor 5 the same is not happening.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue
  • ➖ Addition/Change/Update/Fix
  • ➖ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
🐛 Bug report
Status

Closed: won't fix

Version

3.0

Component

Code

Created by

🇮🇳India vakulrai

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @vakulrai
  • Status changed to Postponed: needs info over 1 year ago
  • 🇨🇦Canada dylan donkersgoed London, Ontario

    @vakulrai Are you certain this functionality came from anchor link? The last site I was working on that had it enabled does not have this on the production site still using CKE4. It also doesn't really look relevant for anchor links - they don't have URLs.

  • Status changed to Active over 1 year ago
  • 🇮🇩Indonesia el7cosmos 🇮🇩 GMT+7

    Yes, this is from anchor link. The module have 3 CKE4 plugins: Anchor, Link, Unlink. See https://git.drupalcode.org/project/anchor_link/-/tree/3.0.x/src/Plugin/C....

    IS is from the Link plugin.

  • Has anyone been successful in retrieving the 'Link Types' such as email or phone?

  • 🇯🇴Jordan Ahmad Khader

    #Dylan Donkersgoed For testing
    3.0.x-dev on ckeditor4
    ckeditor4 breaks when you add a link/unlink using 3.0.x-dex

  • 🇯🇴Jordan Rajab Natshah Jordan

    The 3.0.x-dex branch will not support CKEditor 4 moving on with CKEditor 5

    Use ~2.0 or ~1.0 for CKEditor 4
    Please, report issues for any needed fixes for them.

  • 🇯🇴Jordan Ahmad Khader

    Note that if you're using a version lower than 8.x-2.0 you might need to double-check and change the following from;

        return [
          'LinkToAnchor' => [
            'label' => $this->t('Link to anchor'),
            'image' => $anchor_link_path . '/js/plugins/link/icons/link.png',
          ],
          'UnlinkAnchor' => [
            'label' => $this->t('Unlink Anchor'),
            'image' => $anchor_link_path . '/js/plugins/link/icons/unlink.png',
          ],
          'Anchor' => [
            'label' => $this->t('Anchor'),
            'image' => $anchor_link_path . '/js/plugins/link/icons/anchor.png',
          ],
        ];

    To:

        return [
          'Link' => [
            'label' => $this->t('Link to anchor'),
            'image' => $anchor_link_path . '/js/plugins/link/icons/link.png',
          ],
          'Unlink' => [
            'label' => $this->t('Unlink Anchor'),
            'image' => $anchor_link_path . '/js/plugins/link/icons/unlink.png',
          ],
          'Anchor' => [
            'label' => $this->t('Anchor'),
            'image' => $anchor_link_path . '/js/plugins/link/icons/anchor.png',
          ],
        ];

    And then resave the editor. add Link and Unlink buttons in CKEditor

  • 🇯🇴Jordan Ahmad Khader

    #Rajab Natshah patch can work in both ways. We still need it for ckeditor5 and I also want to showcase the functionality on ckeditor4, so we might be able to find a way to embed the plugin in ckeditor5. its also for people who haven't seen the plugin before so they have the chance to see it.

    There are a couple of challenges we will face in trying to achieve this:

    1. The Drupallink core has changed its plugin name to 'link', which is what we used to call our Link plugin.
    2. Ckeditor5 has removed the advanced link widget, so we might face issues in building our plugin.
  • 🇯🇴Jordan Rajab Natshah Jordan

    Ahmad,

    Not pland to support the (Link or Unlink) in 3.0.x with CKEditor 5
    It is a completely new custom external CKEditor5 library developed by Dylan Donkersgoed from Northern Commerce

    https://github.com/northernco/ckeditor5-anchor-drupal
    https://www.npmjs.com/package/@northernco/ckeditor5-anchor-drupal

    We agreed on only to have the Flag button
    Switch to use Linkit and Advanced Link Attributes
    CKEditor 5 has a new way of doing links with Drupal Core Link + Linkit
    Linkit will be in core or some part of it. At some point

  • 🇯🇴Jordan Ahmad Khader

    I see thanks for the clarification, Rajab.

  • Status changed to Closed: won't fix 11 months ago
  • 🇯🇴Jordan Rajab Natshah Jordan

    Closing the issue as won't fix.

Production build 0.71.5 2024