- Issue created by @alok_singh
- @alok_singh opened merge request.
- Status changed to Needs review
about 1 year ago 7:58am 6 October 2023 - Status changed to Needs work
about 1 year ago 10:13am 9 October 2023 - ๐ฎ๐ณIndia VijaySharma_89
Hi @alok_singh,
MR !12 is working but the toggle Menu is not working on a mobile screen. - First commit to issue fork.
- Status changed to Needs review
10 months ago 6:32am 23 February 2024 - ๐ฎ๐ณIndia adarshv
@Fashion and Beauty
Fixed menu hover or click on both mobile and desktop,
Check above MR !28 Hi, Reviewed mr 28, the menu is working fine for desktop view but for the mobile view still could see toggle menu not working.
- ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia dev16.addweb
Hi, I have modified toggle js and committed code. Now it's is working as expected in mobile screen, Please review.
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi,
I've tested MR!28 on Drupal 10,
Mr is applied cleanly...Test Result:
Menu hover or click is working to open a submenu.RTBC+1
Adding SS for reference
- Status changed to Needs work
4 months ago 11:58am 10 September 2024 - ๐ต๐ญPhilippines cleavinjosh
Hi,
I applied MR!28, it was applied smoothly and the changes were reflected.
โ fashion_beauty git:(1.2.1) curl https://git.drupalcode.org/project/fashion_beauty/-/merge_requests/28.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1580 0 1580 0 0 3785 0 --:--:-- --:--:-- --:--:-- 3779 patching file css/style.css patching file js/custom.js โ fashion_beauty git:(1.2.1) โ
I'll be attaching some videos for the before and after.
Issue/Concern
- There is an inconsistency for the mobile view. The submenu will show when being hovered which should not be since the menu should only appear once the caret button will be clicked. Then, after clicking on the caret, it the hover effect will not take effect and it will still take for more than one click to make the submenus and the hover effect will reappear again.
Please see video: Mobile View Issue.
Please check and advise.
Thank you. - There is an inconsistency for the mobile view. The submenu will show when being hovered which should not be since the menu should only appear once the caret button will be clicked. Then, after clicking on the caret, it the hover effect will not take effect and it will still take for more than one click to make the submenus and the hover effect will reappear again.