- Issue created by @lauriii
- last update
about 1 year ago 30,383 pass - @lauriii opened merge request.
- Status changed to Needs review
about 1 year ago 12:55pm 9 October 2023 - First commit to issue fork.
- last update
about 1 year ago 30,385 pass - Status changed to RTBC
about 1 year ago 8:27pm 9 October 2023 - 🇺🇸United States smustgrave
Only rebased to run test-only run and worked like a charm.
1) Drupal\Tests\field_ui\Functional\ManageFieldsTest::testFieldTypeCardinalityAlter Behat\Mink\Exception\ElementTextException: The text "Greetings from Drupal\field_test\Plugin\Field\FieldType\TestItem::storageSettingsForm" was not found in the text of the element matching css "#edit-field-storage". /builds/issue/drupal-3391912/vendor/behat/mink/src/WebAssert.php:847 /builds/issue/drupal-3391912/vendor/behat/mink/src/WebAssert.php:467 /builds/issue/drupal-3391912/core/modules/field_ui/tests/src/Functional/ManageFieldsTest.php:345 /builds/issue/drupal-3391912/vendor/phpunit/phpunit/src/Framework/TestResult.php:728Reviewing change and seems pretty simple moving the getCardinalityForm up some.
LGTM.
- 🇺🇸United States smustgrave
Saving credit for @lauriii for the actual work.
- last update
about 1 year ago 30,394 pass - last update
about 1 year ago 30,398 pass - last update
about 1 year ago 30,411 pass - First commit to issue fork.
- last update
about 1 year ago 30,414 pass - Status changed to Fixed
about 1 year ago 8:37am 17 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.