Allow field types to override the cardinality container

Issue created by @lauriii
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
30,383 pass
@lauriii opened merge request.
Status changed to Needs review 11 months ago12:55pm 9 October 2023
Comment 11 months ago →
🇫🇮Finland lauriii Finland
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
30,385 pass
Status changed to RTBC 11 months ago8:27pm 9 October 2023

🇺🇸United States smustgrave

Only rebased to run test-only run and worked like a charm.

1) Drupal\Tests\field_ui\Functional\ManageFieldsTest::testFieldTypeCardinalityAlter
Behat\Mink\Exception\ElementTextException: The text "Greetings from Drupal\field_test\Plugin\Field\FieldType\TestItem::storageSettingsForm" was not found in the text of the element matching css "#edit-field-storage".
/builds/issue/drupal-3391912/vendor/behat/mink/src/WebAssert.php:847
/builds/issue/drupal-3391912/vendor/behat/mink/src/WebAssert.php:467
/builds/issue/drupal-3391912/core/modules/field_ui/tests/src/Functional/ManageFieldsTest.php:345
/builds/issue/drupal-3391912/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Reviewing change and seems pretty simple moving the getCardinalityForm up some.

LGTM.

Comment 11 months ago →
🇺🇸United States smustgrave
Saving credit for @lauriii for the actual work.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
30,394 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
30,398 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
30,411 pass
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
30,414 pass

Comment 11 months ago →

System Message

nod_ → committed d2080999 on 11.x

Issue #3391912 by lauriii: Allow field types to override the cardinality...

Status changed to Fixed 11 months ago8:37am 17 October 2023
Comment 11 months ago →
🇫🇷France nod_ Lille
Committed d208099 and pushed to 11.x. Thanks!

Comment 11 months ago →

System Message

nod_ → committed 4280bf15 on 10.2.x

Issue #3391912 by lauriii: Allow field types to override the cardinality...

Comment 10 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Allow field types to override the cardinality container

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities