SDC ComponentElement: Transform slots scalar values to #plain_text instead of throwing an exception

+1

I think this is in line with the Robustness Principle, and I am in favor.

What happens if a non-string scalar is passed? Do we trigger the error then, do we cast it to a string, or do we find an appropriate render array to use for each scenario?

What happens if a non-string scalar is passed? Do we trigger the error then, do we cast it to a string, or do we find an appropriate render array to use for each scenario?

Let's raise the InvalidComponentDataException you are currently raising.

Before doing any modifications, I got some failures from module's tests:

1) Drupal\Tests\sdc\Kernel\ComponentRenderInvalidTest::testInvalidDefinitionModule
Failed asserting that exception of type "Drupal\sdc\Exception\InvalidComponentException" is thrown.
2) Drupal\Tests\sdc\Kernel\ComponentRenderInvalidTest::testInvalidDefinitionTheme
Failed asserting that exception of type "Drupal\sdc\Exception\InvalidComponentException" is thrown.

Maybe I did something wrong while setting up my phpunit test environement.

Those failures will stay after my modification, so I hope I will not miss a test case.

Hi Mateu,

Here is the merge request: https://git.drupalcode.org/project/drupal/-/merge_requests/5044

I have also updated the checkInvalidSlot test:

       '#slots' => [
-        'banner_body' => 'I am an invalid render array.',
+        'banner_body' => new stdClass(),
       ],

I wanted to use a PHP which is not a render array, but it seems Utilities::isRenderArray() is returning TRUE for any array, not only render array. Am I right? If yes, do we need to fix this too?

CC failure in MR

Have not tested.

I pushed a second commit: https://git.drupalcode.org/project/drupal/-/merge_requests/5044/diffs?co...

I hope it is OK now.

Rebased to run test-only feature

There was 1 failure:
1) Drupal\Tests\sdc\Kernel\ComponentRenderTest::testRender
Failed asserting that exception message 'Unable to render component "sdc_test:my-banner". A render array is expected for the slot "banner_body" when using the render element with the "#slots" property' contains 'Unable to render component "sdc_test:my-banner". A render array or a scalar is expected for the slot "banner_body" when using the render element with the "#slots" property'.
/builds/issue/drupal-3391702/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/builds/issue/drupal-3391702/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-3391702/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
FAILURES!
Tests: 2, Assertions: 26, Failures: 1.

Which is good.

The change looks good and matches the proposed solution. Only question I have is even though SDC is experimental will it need a CR for the new way to pass things?

Agreed on the RTBC. I think this improves DX a bit.

Thanks for this!

Created a CR and committed 76fac09 and pushed to 11.x. Cherry-picked all the way to 10.1.x because SDC is experimental. Thanks!

lauriii → closed merge request !5044

Automatically closed - issue fixed for 2 weeks with no activity.