- Issue created by @pdureau
- πͺπΈSpain idiaz.roncero Madrid
+1 to this.
Also, for readability and clarity I think the new public method (
getActiveComponents
) is the best solution. Boolean flags tend to obfuscate what's happening, calls togetAllComponents(TRUE)
or similar are harder to read and understand at first sight for newcomers. - e0ipso Can Picafort
I like this proposal. Let's keep in mind that active component depends heavily on the active theme. This is often overlooked, and specially frustrating when listing the components for an admin screen (that is rendered using an admin theme).
Perhaps we ought to add a parameter
getActiveComponents(using_theme: 'olivero')
. Where the default parameter uses the currently active theme. - First commit to issue fork.
- Assigned to oldeb
- Merge request !6070Issue #3391978 by oldeb, pdureau: SDC: Add a method to retrieve only... β (Open) created by Grimreaper
- Status changed to Needs work
10 months ago 4:50pm 8 January 2024 - π«π·France Grimreaper France π«π·
Created the MR because oldeb was not able to, maybe due to missing permissions. I was with him in video meeting.