- Issue created by @claudiu.cristea
- last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - last update
over 1 year ago 8 pass - last update
over 1 year ago 8 pass - last update
over 1 year ago 2 fail - last update
over 1 year ago 8 pass - last update
over 1 year ago 2 fail - last update
over 1 year ago 8 pass - last update
over 1 year ago 1 fail - last update
over 1 year ago 9 pass - Status changed to Needs review
over 1 year ago 1:11pm 2 October 2023 - π·π΄Romania claudiu.cristea Arad π·π΄
This is ready for review and has tests
- last update
about 1 year ago 2 fail - last update
about 1 year ago 9 pass - last update
about 1 year ago 9 pass - last update
about 1 year ago 9 pass - Status changed to RTBC
about 1 year ago 10:23pm 17 October 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Looks good to me. I've not been an active maintainer here since Drupal 6 so will defer to swentel for the next steps.
- π³π±Netherlands tim_dj Netherlands
This doesn't work out of the box. You need to add "image/svg+xml" to imagecache_external_allowed_mimetypes in imagecache_external.settings
I think this should be either added as default or there should be an UI to enable this.
- π·π΄Romania claudiu.cristea Arad π·π΄
@tim_dj, indeed
imagecache_external_allowed_mimetypes
setting is not exposed in the admin form. But that is not an effect of this issue. I think you can open a follow-up to make this setting editable - π³π±Netherlands tim_dj Netherlands
@claudiu.cristea then at the very least this should be documented because now it just doesn't work out of the box and I had to debug to find the cause
- Status changed to Needs work
about 1 year ago 12:14pm 27 December 2023 - π§πͺBelgium swentel
Cool! I agree however, that the mimetype should be added to the settings as well.
I see 2 options:
1. an update hook: there's an existing one, 'imagecache_external_update_8103' which does this for image/webp.
2. Add the mimetype as soon as you configure the svg settings in the UI.
I kind of prefer number 2: add when you configure tags, remove when svg tags are removed.
- First commit to issue fork.
- π§πͺBelgium herved
It looks like something went wrong with the last merge in 3390948-svg (in , imagecache_external.module
imagecache_sanitize_svg
got removed).
I created a new 3390948-svg-2 branch, rebased on 3.0.x.