Split out a couple more config translation UI tests

For cc issue.

Fixed the unused use statements.

Thanks taking a look at the moves and agree with the placement of the functions. Don't think any test coverage was lost either.

A cspell:ignore needed to move too, probably dictionary changes elsewhere uncovered it.

Saving credits.

See on the MR regarding French vs. German.

I confirmed that this change set is purely moved test code aside from the following changes to that method:

diff --git a/core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php b/core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php
index 579466f730..40b6e5bec6 100644
--- a/core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php
+++ b/core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php
@@ -5,7 +5,7 @@
 use Drupal\Core\Language\Language;
 use Drupal\Core\Language\LanguageInterface;
 
-// cspell:ignore libellé viewsviewfiles
+// cspell:ignore viewsviewfiles
 
 /**
  * Translate settings and entities to various languages.
@@ -124,7 +124,6 @@ public function testSiteInformationTranslationUi() {
    * Tests date format translation.
    */
   public function testDateFormatTranslation() {
-    $this->drupalLogin($this->adminUser);
 
     $this->drupalGet('admin/config/regional/date-time');
 
@@ -151,7 +150,7 @@ public function testDateFormatTranslation() {
       $this->drupalGet($translation_base_url);
 
       // 'Add' link should be present for French translation.
-      $translation_page_url = "$translation_base_url/fr/add";
+      $translation_page_url = "$translation_base_url/de/add";
       $this->assertSession()->linkByHrefExists($translation_page_url);
 
       // Make sure original text is present on this page.
@@ -163,7 +162,7 @@ public function testDateFormatTranslation() {
 
       // Update translatable fields.
       $edit = [
-        'translation[config_names][core.date_format.' . $id . '][label]' => $id . ' - FR',
+        'translation[config_names][core.date_format.' . $id . '][label]' => $id . ' - DE',
         'translation[config_names][core.date_format.' . $id . '][pattern]' => 'D',
       ];
 
@@ -172,16 +171,16 @@ public function testDateFormatTranslation() {
       $this->submitForm($edit, 'Save translation');
 
       // Get translation and check we've got the right value.
-      $override = \Drupal::languageManager()->getLanguageConfigOverride('fr', 'core.date_format.' . $id);
+      $override = \Drupal::languageManager()->getLanguageConfigOverride('de', 'core.date_format.' . $id);
       $expected = [
-        'label' => $id . ' - FR',
+        'label' => $id . ' - DE',
         'pattern' => 'D',
       ];
       $this->assertEquals($expected, $override->get());
 
       // Formatting the date 8 / 27 / 1985 @ 13:37 EST with pattern D should
       // display "Tue".
-      $formatted_date = $this->container->get('date.formatter')->format(494015820, $id, NULL, 'America/New_York', 'fr');
+      $formatted_date = $this->container->get('date.formatter')->format(494015820, $id, NULL, 'America/New_York', 'de');
       $this->assertEquals('Tue', $formatted_date, 'Got the right formatted date using the date format translation pattern.');
     }
   }

Replied on the MR, and pushed a commit changing the comment - it's to make the method compatible with the test class it's being moved to, which only uses German and Spanish at the moment.

Reviewed the whole method and looked at the parent test as well. Looks good now.

Committed to 11.x and 10.2.x. Thanks! As a test performance improvement, this is also a good choice for backport to 10.1.x, but it did not cherry-pick cleanly. Setting PTBP for a 10.1.x backport.

Final patch release of 10.1 is out, so this can go back to "Fixed".

Automatically closed - issue fixed for 2 weeks with no activity.