- Issue created by @catch
- Status changed to Needs review
over 1 year ago 10:24pm 25 September 2023 - last update
over 1 year ago Custom Commands Failed - @catch opened merge request.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 30,363 pass - Status changed to RTBC
over 1 year ago 1:24pm 27 September 2023 - 🇺🇸United States smustgrave
Made the mistake of trying to review in the morning when gitlab is slow.
But looking at what was removed/moved seems to make sense. Naming convention makes sense also.
- last update
over 1 year ago 30,365 pass - 🇫🇮Finland lauriii Finland
Looks like there's some scope creep to address PHPStan violations in
\Drupal\Tests\config_translation\Functional\ConfigTranslationUiTestBase::getTranslationbut since we'd have to update the baseline anyway, it seems fine to just fix the violations here.Committed 2f5c4c5 and pushed to 11.x. Thanks!
- Status changed to Fixed
over 1 year ago 9:43am 29 September 2023 - 🇬🇧United Kingdom catch
Ah yeah I couldn't bring myself to update the baseline, would have taken at least four times as long as fixing it.
Automatically closed - issue fixed for 2 weeks with no activity.