- Issue created by @benjifisher
- πΊπΈUnited States benjifisher Boston area
There are no core migrations that explicitly use the
download
process plugin, but thefile_copy
plugin uses it for remote files:// If the source path or URI represents a remote resource, delegate to the // download plugin. if (!$this->isLocalUri($source)) { return $this->downloadPlugin->transform($value, $migrate_executable, $row, $destination_property); }
So we can use basically the same sample code for both.
Since we already have two examples, we can use one of them for a more complete example, creating a file entity, based on the
d7_file
migration. - last update
over 1 year ago 30,205 pass - @benjifisher opened merge request.
- Status changed to Needs review
over 1 year ago 3:06pm 23 September 2023 - πΊπΈUnited States benjifisher Boston area
This issue is ready for review.
- Status changed to RTBC
over 1 year ago 6:55pm 25 September 2023 - last update
over 1 year ago 30,208 pass - πΊπΈUnited States smustgrave
Change makes sense. Looked at the d7_file.yml for file_copy and see the same.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 12:00am 26 September 2023 - last update
over 1 year ago 30,363 pass - Status changed to Needs review
over 1 year ago 1:02am 26 September 2023 - πΊπΈUnited States benjifisher Boston area
Thanks for catching that. I accepted the suggestion on the MR.
- Status changed to RTBC
over 1 year ago 1:06pm 26 September 2023 - Status changed to Fixed
over 1 year ago 5:56pm 26 September 2023 - πΊπΈUnited States xjm
Committed to 11.x, and backported to 10.1.x as a patch-eligible documentation improvement. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.